Skip to content

Commit c43f6d6

Browse files
committed
Update for 1.26
1 parent a4b5f5c commit c43f6d6

File tree

2 files changed

+35
-14
lines changed

2 files changed

+35
-14
lines changed

keps/sig-storage/1710-selinux-relabeling/README.md

Lines changed: 26 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -55,18 +55,18 @@
5555
Items marked with (R) are required *prior to targeting to a milestone / release*.
5656

5757
- [x] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
58-
- [ ] (R) KEP approvers have approved the KEP status as `implementable`
59-
- [ ] (R) Design details are appropriately documented
60-
- [ ] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
58+
- [x] (R) KEP approvers have approved the KEP status as `implementable`
59+
- [x] (R) Design details are appropriately documented
60+
- [x] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
6161
- [ ] e2e Tests for all Beta API Operations (endpoints)
6262
- [ ] (R) Ensure GA e2e tests for meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
6363
- [ ] (R) Minimum Two Week Window for GA e2e tests to prove flake free
64-
- [ ] (R) Graduation criteria is in place
64+
- [x] (R) Graduation criteria is in place
6565
- [ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
6666
- [ ] (R) Production readiness review completed
6767
- [ ] (R) Production readiness review approved
68-
- [ ] "Implementation History" section is up-to-date for milestone
69-
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
68+
- [x] "Implementation History" section is up-to-date for milestone
69+
- [x] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
7070
- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
7171

7272
## Summary
@@ -508,10 +508,24 @@ _This section must be completed when targeting beta graduation to a release._
508508

509509
* **What are the SLIs (Service Level Indicators) an operator can use to
510510
determine the health of the service?**
511+
511512
- [ ] Metrics
512-
- Metric name:
513-
- [Optional] Aggregation method:
514-
- Components exposing the metric:
513+
- All `errors_total` metrics below cover real errors when a Pod can't start.
514+
It applies to `ReadWriteOncePod` volumes.
515+
- All `warnings_total` metrics below cover **future** errors that would appear if this feature was extended to all volumes.
516+
This will be evaluated in Phase 2.
517+
- 1. `volume_manager_selinux_container_errors_total` + `volume_manager_selinux_container_warnings_total`: Number of errors when kubelet cannot compute SELinux context for a container.
518+
This indicates an error converting SELinux context into SELinux label by github.com/opencontainers/selinux/go-selinux library.
519+
Reading its source code, this should never happen, but one never knows.
520+
1. `volume_manager_selinux_pod_context_mismatch_errors_total` + `volume_manager_selinux_pod_context_mismatch_warnings_total`: Number of errors when a Pod defines different SELinux contexts for its containers that use the same volume.
521+
Before this feature, only one container in such a Pod could access the volume.
522+
With this feature, the Pod won't even start.
523+
This metric captures nr. of failed Pod starts, including periodic retries.
524+
1. `volume_manager_selinux_volume_context_mismatch_errors_total` + `volume_manager_selinux_volume_context_mismatch_warnings_total`: Number of errors when a Pod uses a volume that is already mounted with a different SELinux context than the Pod needs.
525+
Before this feature, both pods would start, but only one such pod could access the volume.
526+
With this feature, one of the Pods won't even start.
527+
- Components exposing the metric: KCM
528+
515529
- [ ] Other (treat as last resort)
516530
- Details:
517531
@@ -653,7 +667,9 @@ _This section must be completed when targeting beta graduation to a release._
653667
654668
## Implementation History
655669
656-
* 1.25: Alpha
670+
* 1.25: Partial implementation of alpha.
671+
* Volume reconstruction after kubelet start does not reconstruct SELinux contexts.
672+
* 1.26: Alpha with everything implemented.
657673
658674
## Drawbacks [optional]
659675

keps/sig-storage/1710-selinux-relabeling/kep.yaml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,21 @@ approvers:
1919
see-also:
2020
- /keps/sig-storage/695-skip-permission-change/README.md
2121
stage: alpha
22-
latest-milestone: "v1.24"
22+
latest-milestone: "v1.26"
2323
milestone:
2424
alpha: "v1.24"
25-
beta: "v1.25"
26-
stable: "v1.27"
25+
beta: "v1.27"
26+
stable: "v1.29"
2727
feature-gates:
2828
- name: SELinuxMountReadWriteOncePod
2929
components:
3030
- kube-apiserver
3131
- kubelet
3232
disable-supported: true
3333
metrics:
34-
# TODO: fill at beta
34+
- volume_manager_selinux_container_errors_total
35+
- volume_manager_selinux_container_warnings_total
36+
- volume_manager_selinux_pod_context_mismatch_errors_total
37+
- volume_manager_selinux_pod_context_mismatch_warnings_total
38+
- volume_manager_selinux_volume_context_mismatch_errors_total
39+
- volume_manager_selinux_volume_context_mismatch_warnings_total

0 commit comments

Comments
 (0)