Skip to content

Commit c6a38f6

Browse files
committed
KEP-4192: remove protobuf tags from API structs
Signed-off-by: Stanislav Láznička <[email protected]>
1 parent 60bf812 commit c6a38f6

File tree

1 file changed

+10
-10
lines changed
  • keps/sig-api-machinery/4192-svm-in-tree

1 file changed

+10
-10
lines changed

keps/sig-api-machinery/4192-svm-in-tree/README.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -132,31 +132,31 @@ type StorageVersionMigration struct {
132132
// Standard object metadata.
133133
// More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
134134
// +optional
135-
metav1.ObjectMeta `json:"metadata,omitempty" protobuf:"bytes,1,opt,name=metadata"`
135+
metav1.ObjectMeta `json:"metadata,omitempty"`
136136
// Specification of the migration.
137137
// +optional
138-
Spec StorageVersionMigrationSpec `json:"spec,omitempty" protobuf:"bytes,2,opt,name=spec"`
138+
Spec StorageVersionMigrationSpec `json:"spec,omitempty"`
139139
// Status of the migration.
140140
// +optional
141-
Status StorageVersionMigrationStatus `json:"status,omitempty" protobuf:"bytes,3,opt,name=status"`
141+
Status StorageVersionMigrationStatus `json:"status,omitempty"`
142142
}
143143

144144
// Spec of the storage version migration.
145145
type StorageVersionMigrationSpec struct {
146146
// The resource that is being migrated. The migrator sends requests to
147147
// the endpoint serving the resource.
148148
// Immutable.
149-
Resource GroupVersionResource `json:"resource" protobuf:"bytes,1,opt,name=resource"`
149+
Resource GroupVersionResource `json:"resource"`
150150
}
151151

152152
// The names of the group, the version, and the resource.
153153
type GroupVersionResource struct {
154154
// The name of the group.
155-
Group string `json:"group,omitempty" protobuf:"bytes,1,opt,name=group"`
155+
Group string `json:"group,omitempty"`
156156
// The name of the version.
157-
Version string `json:"version,omitempty" protobuf:"bytes,2,opt,name=version"`
157+
Version string `json:"version,omitempty"`
158158
// The name of the resource.
159-
Resource string `json:"resource,omitempty" protobuf:"bytes,3,opt,name=resource"`
159+
Resource string `json:"resource,omitempty"`
160160
}
161161

162162
type MigrationConditionType string
@@ -182,7 +182,7 @@ type StorageVersionMigrationStatus struct {
182182
// ResourceVersion to compare with the GC cache for performing the migration.
183183
// This is the current resource version of given group, version and resource when
184184
// kube-controller-manager first observes this StorageVersionMigration resource.
185-
ResourceVersion string `json:"resourceVersion,omitempty" protobuf:"bytes,2,opt,name=resourceVersion"`
185+
ResourceVersion string `json:"resourceVersion,omitempty"`
186186
// LastMigratedResource is used to pick up migration from where it left off in case of failure.
187187
LastMigratedResource string `json:"lastMigratedResourceNameHash,omitempty"`
188188
// TODO: do we need LastMigratedResource? We could always try to migrate all that's
@@ -199,13 +199,13 @@ type StorageVersionMigrationList struct {
199199
// Standard list metadata
200200
// More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
201201
// +optional
202-
metav1.ListMeta `json:"metadata,omitempty" protobuf:"bytes,1,opt,name=metadata"`
202+
metav1.ListMeta `json:"metadata,omitempty"`
203203
// Items is the list of StorageVersionMigration
204204
// +patchMergeKey=type
205205
// +patchStrategy=merge
206206
// +listType=map
207207
// +listMapKey=type
208-
Items []StorageVersionMigration `json:"items" listType:"map" listMapKey:"type" patchStrategy:"merge" patchMergeKey:"type" protobuf:"bytes,2,rep,name=items"`
208+
Items []StorageVersionMigration `json:"items" listType:"map" listMapKey:"type" patchStrategy:"merge" patchMergeKey:"type"`
209209
}
210210
```
211211

0 commit comments

Comments
 (0)