Skip to content

Commit c906d61

Browse files
authored
Merge pull request #4926 from HirazawaUi/fix-kep4396-error
KEP-4396 Fix beta stage description
2 parents 509a2df + 8bd70a9 commit c906d61

File tree

1 file changed

+15
-7
lines changed
  • keps/sig-node/4369-allow-special-characters-environment-variable

1 file changed

+15
-7
lines changed

keps/sig-node/4369-allow-special-characters-environment-variable/README.md

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -153,11 +153,15 @@ These tests will be added:
153153
##### e2e tests
154154

155155
* Add a test to `test/e2e/common/node/configmap.go` to test that the special characters in configmap are consumed by the environment variable.
156-
157156
* Add a test to `test/e2e/common/node/secret.go` to test that the special characters in secret are consumed by the environment variable.
158-
159157
* Add a test to `test/e2e/common/node/expansion` to test environment variable can contain special characters.
160158

159+
We have also added presubmit and periodic test jobs in CI for these e2e tests.
160+
Job names:
161+
162+
- `pull-kubernetes-e2e-relaxed-environment-variable-validation`
163+
- `ci-kubernetes-e2e-relaxed-environment-variable-validation`
164+
161165
### Graduation Criteria
162166

163167
#### Alpha
@@ -224,7 +228,9 @@ Yes.
224228

225229
### Rollout, Upgrade and Rollback Planning
226230

227-
When the feature gate is disabled, workloads that are already running will not be affected. If environment variables contain special characters, changes to fields other than the environment variables will not cause workloads to fail. However, if the environment variable fields are modified, they may fail to recreate Pods or ReplicaSets due to the Apiserver's validation logic, which could result in workload failures.
231+
###### How can a rollout or rollback fail? Can it impact already running workloads?
232+
233+
When the feature gate is disabled, workloads that are already running will not be affected. However, if user update the workloads, they may fail to recreate pods or ReplicaSets due to failing the Apiserver's validation logic, which could cause the workloads to fail.
228234

229235
###### What specific metrics should inform a rollback?
230236

@@ -250,12 +256,12 @@ kubectl get pods --all-namespaces -o json | jq -r '.items[] | select(.spec.conta
250256

251257
###### What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?
252258

253-
According to the test results in https://github.com/HirazawaUi/verfiy-container-env, the container runtime is very lenient with using special characters as environment variables, and almost no failures will occur. However, if unexpected boundary conditions occur, `run_podsandbox_errors_total` can still help us record some problems.
259+
According to the test results in https://github.com/HirazawaUi/verfiy-container-env, the container runtime is very lenient with using special characters as environment variables, and almost no failures will occur.
254260

255-
- [x] Metrics
256-
- Metric name: run_podsandbox_errors_total
261+
- [ ] Metrics
262+
- Metric name:
257263
- [Optional] Aggregation method:
258-
- Components exposing the metric: kubelet
264+
- Components exposing the metric:
259265
- [ ] Other (treat as last resort)
260266
- Details:
261267

@@ -313,6 +319,8 @@ No
313319

314320
\- 2024-08-26: Promote to beta
315321

322+
\- 2024-08-27: Fixed some errors in the beta phase
323+
316324
## Drawbacks
317325

318326
If the envvar name character set is extended, all the things currently consuming and using envvar names from the API will have an impact and may break or be unsafe.

0 commit comments

Comments
 (0)