Skip to content

Commit c9dc769

Browse files
committed
api: make author required
1 parent b3022f4 commit c9dc769

File tree

4 files changed

+10
-14
lines changed

4 files changed

+10
-14
lines changed

api/proposal.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ type Proposal struct {
106106

107107
Title string `json:"title" yaml:"title" validate:"required"`
108108
Number string `json:"kep-number" yaml:"kep-number" validate:"required"`
109-
Authors []string `json:"authors" yaml:",flow"`
109+
Authors []string `json:"authors" yaml:",flow" validate:"required"`
110110
OwningSIG string `json:"owningSig" yaml:"owning-sig" validate:"required"`
111111
ParticipatingSIGs []string `json:"participatingSigs" yaml:"participating-sigs,flow,omitempty"`
112112
Reviewers []string `json:"reviewers" yaml:",flow"`

keps/sig-scheduling/964-binpacking-priority/kep.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
title: "Extending RequestedToCapacityRatio Priority Function to support Resource Bin Packing of Extended Resources - @sudeshsh"
22
kep-number: 964
33
owning-sig: sig-scheduling
4+
authors:
5+
- sudeshsh
46
participating-sigs:
57
- sig-scheduling
68
reviewers:

pkg/repo/testdata/repos/valid/keps/sig-owns-participates/1-the-bare-minimum/kep.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
title: The Bare Minimum
22
kep-number: a non-empty string
3-
# authors:
4-
# - "@alice"
3+
authors:
4+
- alice
55
# TODO: this should fail to load/validate unless owning-sig is sig-owns-participates
66
owning-sig: a non-empty string
77
# TODO: this should fail to load/validate unless status is one of...

pkg/repo/testdata/valid-kep-minimum.yaml

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,16 @@
11
title: minimal
2-
kep-number: 1337
2+
kep-number: 1234
33
authors:
4-
- "@jpbetz"
5-
- "@roycaihw"
6-
- "@sttts"
4+
- "@alice"
5+
- "@beth"
76
owning-sig: sig-api-machinery
87
participating-sigs:
98
- sig-api-machinery
109
- sig-architecture
1110
reviewers:
12-
- "@deads2k"
13-
- "@lavalamp"
14-
- "@liggitt"
15-
- "@mbohlool"
16-
- "@sttts"
11+
- "@carol"
1712
approvers:
18-
- "@deads2k"
19-
- "@lavalamp"
13+
- "@dorothy"
2014
creation-date: 2018-04-15
2115
last-updated: 2018-04-24
2216
status: provisional

0 commit comments

Comments
 (0)