Skip to content

Commit ca70daf

Browse files
committed
address the review
1 parent e8be17a commit ca70daf

File tree

1 file changed

+3
-3
lines changed
  • keps/sig-scheduling/3022-min-domains-in-pod-topology-spread

1 file changed

+3
-3
lines changed

keps/sig-scheduling/3022-min-domains-in-pod-topology-spread/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -429,6 +429,8 @@ logs or events for this purpose.
429429
-->
430430

431431
The operator can query pods with `pod.spec.topologySpreadConstraints.minDomains` field set.
432+
And, after adopting `minDomains` in some Pods, they can confirm that `minDomains` impacts on the scheduling
433+
by observing an increase in `plugin_evaluation_total{plugin="PodTopologySpread",extension_point="Filter"}`.
432434

433435
###### How can someone using this feature know that it is working for their instance?
434436

@@ -486,9 +488,7 @@ Describe the metrics themselves and the reasons why they weren't added (e.g., co
486488
implementation difficulties, etc.).
487489
-->
488490

489-
It was lacking the way to see which filter plugin affected Pod's scheduling results in metrics
490-
(https://github.com/kubernetes/kubernetes/issues/110643),
491-
and we've got `plugin_evaluation_total`.
491+
No.
492492

493493
### Dependencies
494494

0 commit comments

Comments
 (0)