Skip to content

Commit cd58b39

Browse files
committed
fix: update based on the reviews
1 parent 3025bc9 commit cd58b39

File tree

2 files changed

+43
-22
lines changed

2 files changed

+43
-22
lines changed

keps/sig-scheduling/3022-min-domains-in-pod-topology-spread/README.md

Lines changed: 42 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -38,20 +38,20 @@
3838

3939
Items marked with (R) are required _prior to targeting to a milestone / release_.
4040

41-
- [ ] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
42-
- [ ] (R) KEP approvers have approved the KEP status as `implementable`
43-
- [ ] (R) Design details are appropriately documented
44-
- [ ] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
45-
- [ ] e2e Tests for all Beta API Operations (endpoints)
46-
- [ ] (R) Ensure GA e2e tests for meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
47-
- [ ] (R) Minimum Two Week Window for GA e2e tests to prove flake free
48-
- [ ] (R) Graduation criteria is in place
49-
- [ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
50-
- [ ] (R) Production readiness review completed
51-
- [ ] (R) Production readiness review approved
52-
- [ ] "Implementation History" section is up-to-date for milestone
53-
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
54-
- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
41+
- [x] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
42+
- [x] (R) KEP approvers have approved the KEP status as `implementable`
43+
- [x] (R) Design details are appropriately documented
44+
- [x] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
45+
- [x] e2e Tests for all Beta API Operations (endpoints)
46+
- [x] (R) Ensure GA e2e tests for meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
47+
- [x] (R) Minimum Two Week Window for GA e2e tests to prove flake free
48+
- [x] (R) Graduation criteria is in place
49+
- [x] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
50+
- [x] (R) Production readiness review completed
51+
- [x] (R) Production readiness review approved
52+
- [x] "Implementation History" section is up-to-date for milestone
53+
- [x] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
54+
- [x] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
5555

5656
[kubernetes.io]: https://kubernetes.io/
5757
[kubernetes/enhancements]: https://git.k8s.io/enhancements
@@ -237,9 +237,9 @@ This can inform certain test coverage improvements that we want to do before
237237
extending the production code to implement this enhancement.
238238
-->
239239

240-
- `k8s.io/kubernetes/pkg/scheduler/framework/plugins/podtopologyspread`: `2022-06-17` - `86%`
241-
- `k8s.io/kubernetes/pkg/api/pod`: `2022-06-17` - `66.7%`
242-
- `k8s.io/kubernetes/pkg/apis/core/validation`: `2022-06-17` - `82.1%`
240+
- `k8s.io/kubernetes/pkg/scheduler/framework/plugins/podtopologyspread`: `2024-01-28` - `87.3%`
241+
- `k8s.io/kubernetes/pkg/api/pod`: `2024-01-28` - `74.8%`
242+
- `k8s.io/kubernetes/pkg/apis/core/validation`: `2024-01-28` - `83.9%`
243243

244244
##### Integration tests
245245

@@ -280,7 +280,11 @@ So, E2E tests doesn't add extra value to integration tests.
280280

281281
#### Beta (v1.25):
282282

283-
- [ ] This feature will be enabled by default as a Beta feature in v1.25.
283+
- [x] This feature will be enabled by default as a Beta feature in v1.25.
284+
285+
#### GA (v1.30):
286+
287+
- [x] No particular issue is reported to this feature for a certain length of time.
284288

285289
## Production Readiness Review Questionnaire
286290

@@ -481,9 +485,9 @@ Describe the metrics themselves and the reasons why they weren't added (e.g., co
481485
implementation difficulties, etc.).
482486
-->
483487

484-
Yes. It would be useful if we could see which filter plugin affected Pod's scheduling results in metrics.
485-
486-
Issue: https://github.com/kubernetes/kubernetes/issues/110643
488+
It was lacking the way to see which filter plugin affected Pod's scheduling results in metrics
489+
(https://github.com/kubernetes/kubernetes/issues/110643),
490+
and we've got `plugin_evaluation_total`.
487491

488492
### Dependencies
489493

@@ -558,6 +562,20 @@ This through this both in small and large cases, again with respect to the
558562
[supported limits]: https://git.k8s.io/community//sig-scalability/configs-and-limits/thresholds.md
559563
-->
560564

565+
###### Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?
566+
567+
<!--
568+
Focus not just on happy cases, but primarily on more pathological cases
569+
(e.g. probes taking a minute instead of milliseconds, failed pods consuming resources, etc.).
570+
If any of the resources can be exhausted, how this is mitigated with the existing limits
571+
(e.g. pods per node) or new limits added by this KEP?
572+
573+
Are there any tests that were run/should be run to understand performance characteristics better
574+
and validate the declared limits?
575+
-->
576+
577+
No.
578+
561579
### Troubleshooting
562580

563581
<!--
@@ -615,6 +633,9 @@ Major milestones might include:
615633
- 2022-01-14: Initial KEP is merged.
616634
- 2022-03-16: The implementation PRs are merged.
617635
- 2022-05-03: The MinDomain feature is released as alpha feature with Kubernetes v1.24 release.
636+
- 2022-06-23: KEP is updated so that the MinDomain feature is moving to beta with Kubernetes v1.25 release.
637+
- 2022-07-16: The feature gate is changed to be enabled by default.
638+
- 2024-01-15: KEP is updated so that the MinDomain feature is moving to GA with Kubernetes v1.30 release.
618639

619640
## Drawbacks
620641

keps/sig-scheduling/3022-min-domains-in-pod-topology-spread/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ milestone:
2020
alpha: "v1.24"
2121
beta: "v1.25"
2222
stable: "v1.30"
23-
disable-supported: true
23+
disable-supported: false
2424
feature-gates:
2525
- name: MinDomainsInPodTopologySpread
2626
components:

0 commit comments

Comments
 (0)