Skip to content

Commit cd82e55

Browse files
committed
Finish renaming PodResizing condition to PodResizeInProgress
1 parent 2062c22 commit cd82e55

File tree

1 file changed

+12
-12
lines changed
  • keps/sig-node/1287-in-place-update-pod-resources

1 file changed

+12
-12
lines changed

keps/sig-node/1287-in-place-update-pod-resources/README.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ The `ResizePolicy` field is immutable.
298298

299299
#### Resize Status
300300

301-
Resize status will be tracked via 2 new pod conditions: `PodResizePending` and `PodResizing`.
301+
Resize status will be tracked via 2 new pod conditions: `PodResizePending` and `PodResizeInProgress`.
302302

303303
**PodResizePending** will track states where the spec has been resized, but the Kubelet has not yet
304304
allocated the resources. There are two reasons associated with this condition:
@@ -313,7 +313,7 @@ admitted. `lastTransitionTime` will be populated with the time the condition was
313313
will always be `True` when the condition is present - if there is no longer a pending resized
314314
(either the resize was allocated or reverted), the condition will be removed.
315315

316-
**PodResizing** will track in-progress resizes, and should be present whenever allocated resources
316+
**PodResizeInProgress** will track in-progress resizes, and should be present whenever allocated resources
317317
!= acknowledged resources (see [Resource States](#resource-states)). For successful synchronous
318318
resizes, this condition should be short lived, and `reason` and `message` will be left blank. If an
319319
error occurs while actuating the resize, the `reason` will be set to `Error`, and `message` will be
@@ -539,23 +539,23 @@ This is intentionally hitting various edge-cases for demonstration.
539539
- `status.containerStatuses[0].allocatedResources[cpu]` = 1.5
540540
- `acknowledged[cpu]` = 1
541541
- `status.containerStatuses[0].resources.requests[cpu]` = 1
542-
- `status.conditions[type==PodResizing]` added
542+
- `status.conditions[type==PodResizeInProgress]` added
543543
- actual CPU shares = 1024
544544

545545
1. Resize #2: cpu = 2
546546
- apiserver validates the request and accepts the operation
547547
- `spec.containers[0].resources.requests[cpu]` = 2
548548
- `status.containerStatuses[0].allocatedResources[cpu]` = 1.5
549549
- `status.containerStatuses[0].resources.requests[cpu]` = 1
550-
- `status.conditions[type==PodResizing]`
550+
- `status.conditions[type==PodResizeInProgress]`
551551
- actual CPU shares = 1024
552552

553553
1. Container runtime applied cpu=1.5
554554
- `spec.containers[0].resources.requests[cpu]` = 2
555555
- `status.containerStatuses[0].allocatedResources[cpu]` = 1.5
556556
- `acknowledged[cpu]` = 1.5
557557
- `status.containerStatuses[0].resources.requests[cpu]` = 1
558-
- `status.conditions[type==PodResizing]`
558+
- `status.conditions[type==PodResizeInProgress]`
559559
- actual CPU shares = 1536
560560

561561
1. kubelet syncs the pod, and sees resize #2 (cpu = 2)
@@ -565,7 +565,7 @@ This is intentionally hitting various edge-cases for demonstration.
565565
- `acknowledged[cpu]` = 1.5
566566
- `status.containerStatuses[0].resources.requests[cpu]` = 1.5
567567
- `status.conditions[type==PodResizePending].type` = `"Deferred"`
568-
- `status.conditions[type==PodResizing]` removed
568+
- `status.conditions[type==PodResizeInProgress]` removed
569569
- actual CPU shares = 1536
570570

571571
1. Resize #3: cpu = 1.6
@@ -583,23 +583,23 @@ This is intentionally hitting various edge-cases for demonstration.
583583
- `acknowledged[cpu]` = 1.5
584584
- `status.containerStatuses[0].resources.requests[cpu]` = 1.5
585585
- `status.conditions[type==PodResizePending]` removed
586-
- `status.conditions[type==PodResizing]` added
586+
- `status.conditions[type==PodResizeInProgress]` added
587587
- actual CPU shares = 1536
588588

589589
1. Container runtime applied cpu=1.6
590590
- `spec.containers[0].resources.requests[cpu]` = 1.6
591591
- `status.containerStatuses[0].allocatedResources[cpu]` = 1.6
592592
- `acknowledged[cpu]` = 1.6
593593
- `status.containerStatuses[0].resources.requests[cpu]` = 1.5
594-
- `status.conditions[type==PodResizing]`
594+
- `status.conditions[type==PodResizeInProgress]`
595595
- actual CPU shares = 1638
596596

597597
1. Kubelet syncs the pod
598598
- `spec.containers[0].resources.requests[cpu]` = 1.6
599599
- `status.containerStatuses[0].allocatedResources[cpu]` = 1.6
600600
- `acknowledged[cpu]` = 1.6
601601
- `status.containerStatuses[0].resources.requests[cpu]` = 1.6
602-
- `status.conditions[type==PodResizing]` removed
602+
- `status.conditions[type==PodResizeInProgress]` removed
603603
- actual CPU shares = 1638
604604

605605
1. Resize #4: cpu = 100
@@ -721,18 +721,18 @@ Impacts of a restart outside of resource configuration are out of scope.
721721
1. Updated pod is synced: Check if pod can be admitted
722722
- No: add `PodResizePending` condition with type `Deferred`, no change to allocated resources
723723
- Restart: redo admission check, still deferred.
724-
- Yes: add `PodResizing` condition, update allocated checkpoint
724+
- Yes: add `PodResizeInProgress` condition, update allocated checkpoint
725725
- Restart before update: readmit, then update allocated
726726
- Restart after update: allocated != acknowledged --> proceed with resize
727727
1. Allocated != Acknowledged
728728
- Trigger an `UpdateContainerResources` CRI call, then update Acknowledged resources on success
729729
- Restart before CRI call: allocated != acknowledged, will still trigger the update call
730730
- Restart after CRI call, before acknowledged update: will redo update call
731731
- Restart after acknowledged update: allocated == acknowledged, condition removed
732-
- In all restart cases, `LastTransitionTime` is propagated from the old pod status `PodResizing`
732+
- In all restart cases, `LastTransitionTime` is propagated from the old pod status `PodResizeInProgress`
733733
condition, and remains unchanged.
734734
1. PLEG updates PodStatus cache, triggers pod sync
735-
- Pod status updated with actual resources, `PodResizing` condition removed
735+
- Pod status updated with actual resources, `PodResizeInProgress` condition removed
736736
- Desired == Allocated == Acknowledged, no resize changes needed.
737737

738738
#### Notes

0 commit comments

Comments
 (0)