Skip to content

Commit ce24499

Browse files
committed
update latest milsetone to v1.35
Signed-off-by: Andrew Sy Kim <[email protected]>
1 parent e8c44f9 commit ce24499

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

keps/sig-node/4742-node-topology-downward-api/README.md

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ creation but not guaranteed to be immutable and thus should be treated as so.
171171

172172
* A built-in Kubernetes admission plugin, `PodTopologyLabels` will be introduced in kube-apiserver
173173
* The `PodTopologyLabels` admission plugin is responsible for mutating `pods/binding` subresource, adding topology labels matching the target Node.
174-
* `PodTopologyLabels` admission will overwrite `topology.k8s.io/*` labels on Pods.
174+
* `PodTopologyLabels` admission will overwrite `topology.kubernetes.io/*` labels on Pods.
175175
* A feature gate, `PodTopologyLabelsAdmission` will be introduced in v1.33. Alpha and disabled by default.
176176
The `PodTopologyLabels` admission plugin can only be set when this feature gate is enabled.
177177
* The Binding REST implementation will be updated to copy all labels from `pods/binding` subresource into Pods.
@@ -314,11 +314,9 @@ No.
314314

315315
### Monitoring Requirements
316316

317-
TODO for GA.
318-
319317
###### How can an operator determine if the feature is in use by workloads?
320318

321-
N/A
319+
They can check if new Pods contain the `topology.kubernetes.io/*` labels.
322320

323321
###### How can someone using this feature know that it is working for their instance?
324322

@@ -338,15 +336,15 @@ N/A
338336

339337

340338
- [X] Metrics
341-
- Metric name: `pod_scheduling_attempts`
339+
- Metric name: `pod_scheduling_attempts`, `scheduler_scheduling_attempt_duration_seconds`
342340
- [Optional] Aggregation method:
343341
- Components exposing the metric: kube-scheduler
344342
- [] Other (treat as last resort)
345343
- Details: SLI are not necessary for this admission plugin
346344

347345
###### Are there any missing metrics that would be useful to have to improve observability of this feature?
348346

349-
No, we can use `pod_scheduling_attempts`.
347+
No, we can use `pod_scheduling_attempts` and `scheduler_scheduling_attempt_duration_seconds`.
350348

351349
### Dependencies
352350

@@ -394,9 +392,9 @@ Little impact as this feature is only relevant when scheduling and running Pods,
394392

395393
###### What are other known failure modes?
396394

397-
Not all Kubernetes clusters have nodes that have topology labels. Requesting topology information
398-
via downward API in these clusters will result in Pods failing to start or empty values returned
399-
via downward API.
395+
Not all Kubernetes clusters have Nodes with topology labels. Requesting topology information
396+
in these clusters will result in empty values returned via downward API and some
397+
applications failing to start if they rely on this information.
400398

401399
###### What steps should be taken if SLOs are not being met to determine the problem?
402400

keps/sig-node/4742-node-topology-downward-api/kep.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@ see-also:
2121
replaces:
2222

2323
# The target maturity stage in the current dev cycle for this KEP.
24-
stage: alpha
24+
stage: beta
2525

2626
# The most recent milestone for which work toward delivery of this KEP has been
2727
# done. This can be the current (upcoming) milestone, if it is being actively
2828
# worked on.
29-
latest-milestone: "v1.34"
29+
latest-milestone: "v1.35"
3030

3131
# The milestone at which this feature was, or is targeted to be, at each stage.
3232
milestone:

0 commit comments

Comments
 (0)