Skip to content

Commit cf0c83e

Browse files
authored
Merge pull request #5612 from richabanker/flagz-prr
Update ComponentFlagz milestones and PRR #5611
2 parents f4eaa70 + 38ef49a commit cf0c83e

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

keps/sig-instrumentation/4828-component-flagz/README.md

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ This section must be completed when targeting beta to a release.
377377

378378
This feature should not cause rollout failures. If it does, we can disable the feature. In the worst
379379
case, it is possible it could cause runtime failures, but it is highly unlikely we would not detect this
380-
with existing tests.
380+
with existing tests. The endpoint is intended to provide enhanced observability into component state.
381381

382382
###### What specific metrics should inform a rollback?
383383

@@ -437,6 +437,7 @@ This is a debugging feature and not something that workloads depend on. Therefor
437437
###### What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?
438438

439439
This enhancement proposes data that can be used to determine the health of the component.
440+
(though this endpoint is not intended to be used for alerting.)
440441

441442
###### Are there any missing metrics that would be useful to have to improve observability of this feature?
442443

@@ -452,11 +453,11 @@ No, each component's flagz is independent.
452453

453454
###### Will enabling / using this feature result in any new API calls?
454455

455-
No
456+
Yes, enabling this feature will result in a new HTTP endpoint (/flagz) being served by each component (including apiserver). However, this is not a Kubernetes API type or resource; it is a non-resource endpoint that provides component flag information for debugging and observability. No new Kubernetes API objects or resource types are introduced.
456457

457458
###### Will enabling / using this feature result in introducing new API types?
458459

459-
No.
460+
No, this feature does not introduce new Kubernetes API types or resources. While the flagz endpoint uses a structured JSON response with Group/Version/Kind for content negotiation and consistency, it is not a Kubernetes API object and is not managed or persisted by the API server. The GVK is used solely to provide a predictable format for clients querying the endpoint.
460461

461462
###### Will enabling / using this feature result in any new calls to the cloud provider?
462463

@@ -486,14 +487,17 @@ flagz endpoint for apiserver will not be available if the API server itself is d
486487

487488
###### What are other known failure modes?
488489

489-
Overreliance on flagz for critical monitoring. We will clearly document the intended use cases and limitations of the flagz endpoint, emphasizing that it's primarily for informational and troubleshooting purposes, not real-time monitoring or alerting.
490+
Overreliance on flagz for critical monitoring. We will clearly document the intended use cases and limitations of the flagz endpoint, emphasizing that it's primarily for informational and troubleshooting purposes.
490491

491492
###### What steps should be taken if SLOs are not being met to determine the problem?
492493

493494
The feature can be disabled by setting the feature-gate to false if the performance impact of it is not tolerable.
494495

495496
## Implementation History
496497

498+
- 1.32: New `flagz` endpoint introduced for [apiserver](https://github.com/kubernetes/kubernetes/pull/127581)
499+
- 1.33: `/flagz` enablement extended to [kubelet](https://github.com/kubernetes/kubernetes/pull/128857), [scheduler](https://github.com/kubernetes/kubernetes/pull/128818), [controller-manager](https://github.com/kubernetes/kubernetes/pull/128824), and [kube-proxy](https://github.com/kubernetes/kubernetes/pull/128985)
500+
497501
## Drawbacks
498502

499503
## Alternatives

keps/sig-instrumentation/4828-component-flagz/kep.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@ stage: alpha
2020
# The most recent milestone for which work toward delivery of this KEP has been
2121
# done. This can be the current (upcoming) milestone, if it is being actively
2222
# worked on.
23-
latest-milestone: "v1.32"
23+
latest-milestone: "v1.35"
2424

2525
# The milestone at which this feature was, or is targeted to be, at each stage.
2626
milestone:
2727
alpha: "v1.32"
28-
beta: "v1.33"
29-
stable: "v1.34"
28+
beta: "v1.36"
29+
stable: "v1.37"
3030

3131
feature-gates:
3232
- name: ComponentFlagz

0 commit comments

Comments
 (0)