Skip to content

Commit d26a46e

Browse files
authored
Merge pull request #4432 from jsafrane/reconstruction-ga
Graduate NewVolumeManagerReconstruction GA
2 parents 89c88fc + b510823 commit d26a46e

File tree

3 files changed

+30
-9
lines changed

3 files changed

+30
-9
lines changed

keps/prod-readiness/sig-storage/3756.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,5 @@ kep-number: 3756
66
# approver: "@deads2k" # as part of #1710
77
beta:
88
approver: "@deads2k"
9+
stable:
10+
approver: "@deads2k"

keps/sig-storage/3756-volume-reconstruction/README.md

Lines changed: 25 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -104,19 +104,19 @@ SIG Architecture for cross-cutting KEPs).
104104

105105
Items marked with (R) are required *prior to targeting to a milestone / release*.
106106

107-
- [ ] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
108-
- [ ] (R) KEP approvers have approved the KEP status as `implementable`
107+
- [X] (R) Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR)
108+
- [X] (R) KEP approvers have approved the KEP status as `implementable`
109109
- [X] (R) Design details are appropriately documented
110110
- [X] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input (including test refactors)
111-
- [ ] e2e Tests for all Beta API Operations (endpoints)
111+
- [ ] e2e Tests for all Beta API Operations (endpoints)
112112
- [ ] (R) Ensure GA e2e tests meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
113113
- [ ] (R) Minimum Two Week Window for GA e2e tests to prove flake free
114114
- [X] (R) Graduation criteria is in place
115115
- [ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
116-
- [ ] (R) Production readiness review completed
116+
- [X] (R) Production readiness review completed
117117
- [ ] (R) Production readiness review approved
118118
- [X] "Implementation History" section is up-to-date for milestone
119-
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
119+
- [X] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
120120
- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
121121

122122
[kubernetes.io]: https://kubernetes.io/
@@ -566,6 +566,9 @@ https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-cri-containerd-e2e-cos-gc
566566
> "https://35.247.99.121/api/v1/namespaces": dial tcp 35.247.99.121:443:
567567
> connect: connection refused
568568
569+
A whole new job was added to ensure static pods can start when kubelet restarts: [ci-kubernetes-e2e-storage-kind-disruptive](https://testgrid.k8s.io/sig-storage-kubernetes#kind-disruptive).
570+
There was a single installation flake in the last 14 days (captured on 2024-01-23).
571+
569572
### Graduation Criteria
570573

571574
#### Alpha
@@ -769,7 +772,7 @@ Longer term, we may want to require automated upgrade/rollback tests, but we
769772
are missing a bunch of machinery and tooling and can't do that now.
770773
-->
771774

772-
Not yet. This will be a manual test.
775+
Yes, see https://github.com/kubernetes/enhancements/issues/3756#issuecomment-1906255361 (and expand `Details`).
773776

774777
###### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?
775778

@@ -985,6 +988,20 @@ This through this both in small and large cases, again with respect to the
985988

986989
No.
987990

991+
###### Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?
992+
993+
<!--
994+
Focus not just on happy cases, but primarily on more pathological cases
995+
(e.g. probes taking a minute instead of milliseconds, failed pods consuming resources, etc.).
996+
If any of the resources can be exhausted, how this is mitigated with the existing limits
997+
(e.g. pods per node) or new limits added by this KEP?
998+
999+
Are there any tests that were run/should be run to understand performance characteristics better
1000+
and validate the declared limits?
1001+
-->
1002+
1003+
No.
1004+
9881005
### Troubleshooting
9891006

9901007
<!--
@@ -1045,6 +1062,8 @@ Ensure that:
10451062

10461063
* 1.27: Splitting out as a separate KEP, targeting Beta in this release.
10471064

1065+
* 1.30: GA.
1066+
10481067
<!--
10491068
Major milestones in the lifecycle of a KEP should be tracked in this section.
10501069
Major milestones might include:

keps/sig-storage/3756-volume-reconstruction/kep.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,18 @@ see-also:
1818
replaces:
1919

2020
# The target maturity stage in the current dev cycle for this KEP.
21-
stage: beta
21+
stage: stable
2222

2323
# The most recent milestone for which work toward delivery of this KEP has been
2424
# done. This can be the current (upcoming) milestone, if it is being actively
2525
# worked on.
26-
latest-milestone: "v1.27"
26+
latest-milestone: "v1.30"
2727

2828
# The milestone at which this feature was, or is targeted to be, at each stage.
2929
milestone:
3030
alpha: "v1.26" # as part of /keps/sig-storage/1710-selinux-relabeling
3131
beta: "v1.27"
32-
stable: "v1.29"
32+
stable: "v1.30"
3333

3434
# The following PRR answers are required at alpha release
3535
# List the feature gate name and the components for which it must be enabled

0 commit comments

Comments
 (0)