Skip to content

Commit d319cec

Browse files
committed
address comments
1 parent 756f008 commit d319cec

File tree

1 file changed

+5
-5
lines changed
  • keps/sig-network/1880-multiple-service-cidrs

1 file changed

+5
-5
lines changed

keps/sig-network/1880-multiple-service-cidrs/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -254,9 +254,9 @@ The new allocation mode requires:
254254

255255
- 2 new API objects ServiceCIDR and IPAddress in networking.k8s.io/v1alpha1, see <https://groups.google.com/g/kubernetes-sig-api-machinery/c/S0KuN_PJYXY/m/573BLOo4EAAJ>. The ServiceCIDR will be protected with a finalizer, the IPAddress object doesn't need a finalizer because the APIserver always release and delete the IPAddress after the Service has been deleted.
256256
- 1 new allocator implementing current `allocator.Interface`, that runs in each apiserver, and uses the new ServiceCIDRs objects to allocate IPs for Services.
257-
- 1 new repair loop that runs in the apiserver that reconciles the Services with the IPAddresses, repairing
258-
Services, garbage collecting orphan IPAddresses and handling the upgrade from the old allocators.
259-
- 1 new controller that handles the bootstrap process and the ServiceCIDR object, it participates on the ServiceCIDR deletion, the guarantee that each IPAddresses has a ServiceCIDR associated.
257+
- 1 new repair loop that runs in the apiserver that reconciles the Services with the IPAddresses: repair
258+
Services, garbage collecting orphan IPAddresses and handle the upgrade from the old allocators.
259+
- 1 new controller that handles the bootstrap process and the ServiceCIDR object. This controllers participates on the ServiceCIDR deletion, guaranteeing that the existing IPaddresses always have a ServiceCIDR associated.
260260

261261
[![](https://mermaid.ink/img/pako:eNp9UstqwzAQ_BWxx5IcCqUHUwrFacGXYJLeqh620tpV0SNIcsAk_vfKjpNiJ3QvYmdGs7NIBxBOEmQgNIawUlh7NNyyVAPCtuT3StDhhPWV6yZE8kXJQvTK1jeYwD4-52RRvqFRWlFPjk17Rbel00q07G7av7c7Omm7G-HyYrXJna1UfYm5RkOzfEW5f7iGHifQxL0oX6T0FMJ_rhuqmPv6ScfE4VynbszJONxzYE_H5fL4PDaXIVkCUGsnMFLgMLn4t-DcYj23EM5GVHZwgAUY8gaVTA88LMEhfpMhDr1UUoWNjr2yS9JmJ9PoV6mi85BVqAMtAJvotq0VkEXf0Fk0_pNR1f0CyVS2dw)](https://mermaid.live/edit#pako:eNp9UstqwzAQ_BWxx5IcCqUHUwrFacGXYJLeqh620tpV0SNIcsAk_vfKjpNiJ3QvYmdGs7NIBxBOEmQgNIawUlh7NNyyVAPCtuT3StDhhPWV6yZE8kXJQvTK1jeYwD4-52RRvqFRWlFPjk17Rbel00q07G7av7c7Omm7G-HyYrXJna1UfYm5RkOzfEW5f7iGHifQxL0oX6T0FMJ_rhuqmPv6ScfE4VynbszJONxzYE_H5fL4PDaXIVkCUGsnMFLgMLn4t-DcYj23EM5GVHZwgAUY8gaVTA88LMEhfpMhDr1UUoWNjr2yS9JmJ9PoV6mi85BVqAMtAJvotq0VkEXf0Fk0_pNR1f0CyVS2dw)
262262

@@ -312,7 +312,7 @@ the rest of the apiservers will race and the winner will set the configuration o
312312
Pros:
313313
- Simple to implement
314314
- Align with current behavior of kubernetes.default, though this can be a Con as well, since this
315-
doesn't be the expected
315+
the existing behavior was unexpected
316316
Cons:
317317
- Requires manual intervention
318318
@@ -724,7 +724,7 @@ Service implementation (kube-proxy, ...) is able to handle those IPs.
724724
Example:
725725

726726
- flags set to 10.0.0.0/20
727-
- upgrade to 1.25 with alpha gate
727+
- upgrade to N+1 with alpha gate
728728
- apiserver create a default ServiceCIDR object for 10.0.0.0/20
729729
- user creates a new ServiceCIDR for 192.168.1.0/24
730730
- create a Service which gets 192.168.1.1

0 commit comments

Comments
 (0)