Skip to content

Commit d3fcad2

Browse files
committed
Delegate FSGroup to CSI KEP: remove requirement of standalone fsgroup metric
1 parent 1a4f862 commit d3fcad2

File tree

1 file changed

+6
-4
lines changed
  • keps/sig-storage/2317-fsgroup-on-mount

1 file changed

+6
-4
lines changed

keps/sig-storage/2317-fsgroup-on-mount/README.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,9 @@ fields of API types, flags, etc.?**
234234
_This section must be completed when targeting beta graduation to a release._
235235

236236
* **How can an operator determine if the feature is in use by workloads?**
237-
We are going to split the metric that captures mount and permission timings. The full details are available in - https://github.com/kubernetes/kubernetes/issues/98667
237+
The feature is in use if the feature gate DelegateFSGroupToCSIDriver is enabled in kubelet, and the CSI driver supports the `VOLUME_MOUNT_GROUP` node service capability.
238+
239+
We have considered introducing a new metric with a label that identifies which fsgroup logic is used (https://github.com/kubernetes/kubernetes/issues/98667), but because this feature is small and simple enough, the benefit of such a label would be marginal.
238240

239241
* **What are the SLIs (Service Level Indicators) an operator can use to determine
240242
the health of the service?**
@@ -257,8 +259,8 @@ the health of the service?**
257259

258260
* **Are there any missing metrics that would be useful to have to improve observability
259261
of this feature?**
260-
261-
https://github.com/kubernetes/kubernetes/issues/98667 as mentioned above - aiming to implement this as part of beta.
262+
263+
No
262264

263265
### Dependencies
264266

@@ -348,7 +350,7 @@ _This section must be completed when targeting beta graduation to a release._
348350
In addition to existing k8s volume and CSI failure modes:
349351

350352
- Driver fails to apply FSGroup (due to a driver error).
351-
- Detection: SLI above, in conjunction with the metric in https://github.com/kubernetes/kubernetes/issues/98667 to determine if this feature is being used.
353+
- Detection: SLI above, in conjunction with the `DelegateFSGroupToCSIDriver` feature gate and `VOLUME_MOUNT_GROUP` node service capability in the CSI driver to determine if this feature is being used.
352354
- Mitigations: Revert the CSI driver version to one without the issue, or avoid specifying an FSGroup in the pod's security context, if possible.
353355
- Diagnostics: Depends on the driver. Generally look for FSGroup-related messages in `NodeStageVolume` and `NodePublishVolume` logs.
354356
- Testing: Will add an e2e test with a test driver (csi-driver-host-path) simulating a FSGroup failure.

0 commit comments

Comments
 (0)