You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: keps/sig-node/2400-node-swap/README.md
+6-4Lines changed: 6 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -449,11 +449,13 @@ As beta2 was being worked on, we discovered use cases where `--fail-swap-on=fals
449
449
Kind e2e tests run kubelet with `--fail-swap-on=false` and
450
450
the default developer configuration for `hack/local-up-cluster` allows for running developer clusters with swap enabled.
451
451
452
-
We need to support the `--fail-swap-on=false` for both cgroup v1 and cgroupv2. We will not support KEP-2400 with cgroup v1.
453
-
So when one wants to GA this feature, we need to have a way to disable workloads from using swap while keeping the feature toggle on.
454
-
To address this, we will propose a new field to `MemorySwap` called `NoSwap`. This will disable swap usage on the node while keeping the feature active.
452
+
Now, `--fail-swap-on=false` is supported for both cgroup v1 and cgroupv2 although KEP-2400 does not support cgroup v1.
453
+
This is achieved by the newly introduced `MemorySwap` called `NoSwap`, which serves as the default swap behavior, that
454
+
will disable swap usage on the node while keeping the feature active.
455
+
In addition, nodes that support cgroups v1 only would be able to only use `NoSwap`, i.e. in such environments containers
456
+
will be restricted from having access to swap.
455
457
456
-
This can address existing use cases where `--fail-swap-on=false` in cgroupv1 and still allow us to turn this feature on.
458
+
This addresses existing use cases where `--fail-swap-on=false` in cgroupv1 and still allow us to turn this feature on.
0 commit comments