Skip to content

Commit d9e7361

Browse files
committed
Add PRR approver
Signed-off-by: kerthcet <[email protected]>
1 parent 6cd60dd commit d9e7361

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

keps/prod-readiness/sig-scheduling/3094.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,5 @@ alpha:
33
approver: "@wojtek-t"
44
beta:
55
approver: "@wojtek-t"
6+
stable:
7+
approver: "@wojtek-t"

keps/sig-scheduling/3094-pod-topology-spread-considering-taints/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,8 @@ Items marked with (R) are required *prior to targeting to a milestone / release*
138138
- [ ] (R) Ensure GA e2e tests for meet requirements for [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
139139
- [ ] (R) Minimum Two Week Window for GA e2e tests to prove flake free
140140
- [x] (R) Graduation criteria is in place
141-
- [ ] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
142-
- [ ] (R) Production readiness review completed
141+
- [x] (R) [all GA Endpoints](https://github.com/kubernetes/community/pull/1806) must be hit by [Conformance Tests](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md)
142+
- [x] (R) Production readiness review completed
143143
- [ ] (R) Production readiness review approved
144144
- [x] "Implementation History" section is up-to-date for milestone
145145
- [x] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
@@ -566,7 +566,7 @@ feature, can it break the existing applications?).
566566
567567
NOTE: Also set `disable-supported` to `true` or `false` in `kep.yaml`.
568568
-->
569-
Yes, we can just disable the feature gate.
569+
No, but once you leave the related fields unset, this feature will not work.
570570

571571
###### What happens if we reenable the feature if it was previously rolled back?
572572
The policies are respected again.

keps/sig-scheduling/3094-pod-topology-spread-considering-taints/kep.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,3 +39,7 @@ feature-gates:
3939
- kube-scheduler
4040

4141
disable-supported: false
42+
43+
metrics:
44+
- plugin_execution_duration_seconds{plugin="PodTopologySpread"}
45+
- schedule_attempts_total{result="error|unschedulable"}

0 commit comments

Comments
 (0)