Skip to content

Commit debf47d

Browse files
committed
keps/sig-testing: declare 2291 stable
specifically - retroactively refresh; this KEP was completed well before we migrated over to the new format, so it's best guess only for things I filled in - drop the `@` from users so things don't need to be quote-wrapped
1 parent c7684d6 commit debf47d

File tree

2 files changed

+39
-41
lines changed

2 files changed

+39
-41
lines changed

keps/sig-testing/2291-presubmit-config-inside-the-tested-repo/README.md

Lines changed: 25 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -13,35 +13,17 @@
1313
- [Risks and Mitigations](#risks-and-mitigations)
1414
- [Security](#security)
1515
- [Components that need the <code>Presubmit</code> configuration but do not have a <code>git ref</code> to work on](#components-that-need-the--configuration-but-do-not-have-a--to-work-on)
16+
- [Graduation Criteria](#graduation-criteria)
17+
- [Alpha -&gt; Beta Graduation](#alpha---beta-graduation)
18+
- [Beta -&gt; Stable Graduation](#beta---stable-graduation)
1619
- [Implementation History](#implementation-history)
1720
<!-- /toc -->
1821

1922
## Release Signoff Checklist
2023

21-
**ACTION REQUIRED:** In order to merge code into a release, there must be an issue in [kubernetes/enhancements] referencing this KEP and targeting a release milestone **before [Enhancement Freeze](https://github.com/kubernetes/sig-release/tree/master/releases)
22-
of the targeted release**.
23-
24-
For enhancements that make changes to code or processes/procedures in core Kubernetes i.e., [kubernetes/kubernetes], we require the following Release Signoff checklist to be completed.
25-
26-
Check these off as they are completed for the Release Team to track. These checklist items _must_ be updated for the enhancement to be released.
27-
28-
- [ ] kubernetes/enhancements issue in release milestone, which links to KEP (this should be a link to the KEP location in kubernetes/enhancements, not the initial KEP PR)
29-
- [ ] KEP approvers have set the KEP status to `implementable`
30-
- [ ] Design details are appropriately documented
31-
- [ ] Test plan is in place, giving consideration to SIG Architecture and SIG Testing input
32-
- [ ] Graduation criteria is in place
33-
- [ ] "Implementation History" section is up-to-date for milestone
34-
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
35-
- [ ] Supporting documentation e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
36-
37-
**Note:** Any PRs to move a KEP to `implementable` or significant changes once it is marked `implementable` should be approved by each of the KEP approvers. If any of those approvers is no longer appropriate than changes to that list should be approved by the remaining approvers and/or the owning SIG (or SIG-arch for cross cutting KEPs).
38-
39-
**Note:** This checklist is iterative and should be reviewed and updated every time this enhancement is being considered for a milestone.
40-
41-
[kubernetes.io]: https://kubernetes.io/
42-
[kubernetes/enhancements]: https://github.com/kubernetes/enhancements/issues
43-
[kubernetes/kubernetes]: https://github.com/kubernetes/kubernetes
44-
[kubernetes/website]: https://github.com/kubernetes/website
24+
N/A - this KEP is related to code solely in kubernetes/test-infra that is not
25+
being used as part of the development or release process for
26+
kubernetes/kubernetes
4527

4628
## Summary
4729

@@ -149,11 +131,24 @@ Components that need the `Presubmit` config but do not have a git reference at h
149131
can not work as before with `inrepoconfig` because the list of Presubmits depends on
150132
the `ref`. This limitation will be documented.
151133

134+
### Graduation Criteria
135+
136+
#### Alpha -> Beta Graduation
137+
138+
* Presubmits implemented
139+
* Actively used in production by at least one prow deployment
140+
141+
#### Beta -> Stable Graduation
142+
143+
* Postsubmits implemeneted
144+
* Actively used in production by at least one prow deployment for more than six months
145+
152146
## Implementation History
153147

154-
* A basic but functioning [prototype](https://github.com/kubernetes/test-infra/pull/12836)
155-
for this feature was created that served as initial basis for this KEP.
156-
* A non-working [sketch pull request](https://github.com/kubernetes/test-infra/pull/13342) that shows which parts of Prow need to be touched
157-
and how the signatures for the newly-added functions look like was created to
158-
be the basis for a discussion on how exactly an implementation could look like
159-
* Current work is being tracked via a [GitHub tracking issue](https://github.com/kubernetes/test-infra/issues/13370)
148+
* 2019-06-19 - Created [basic functional prototype](https://github.com/kubernetes/test-infra/pull/12836) as basis for this KEP
149+
* 2019-07-19 - Created [non-functional sketch PR](https://github.com/kubernetes/test-infra/pull/13342) for discussion on scope and implementation
150+
* 2019-07-19 - Created [GitHub tracking issue](https://github.com/kubernetes/test-infra/issues/13370)
151+
* 2019-11-27 - Implemented [Support for in-repo presubmits](https://github.com/kubernetes/test-infra/pull/14866)
152+
* 2020-01-14 - Implemented [Support for in-repo postsubmits](https://github.com/kubernetes/test-infra/pull/15667)
153+
* 2020-03-18 - Declared [done](https://github.com/kubernetes/test-infra/issues/13370#issuecomment-600578245)
154+
* 2021-08-16 - Retroactive stable declaration ([docs](https://github.com/kubernetes/test-infra/blob/master/prow/inrepoconfig.md))
Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,23 @@
11
title: Presubmit config inside the tested repo
22
kep-number: 2291
33
authors:
4-
- "@alvaroaleman"
4+
- alvaroaleman
55
owning-sig: sig-testing
66
participating-sigs:
77
- sig-testing
88
reviewers:
9-
- "@stevekuznetsov"
10-
- "@cjwagner"
9+
- stevekuznetsov
10+
- cjwagner
1111
approvers:
12-
- "@stevekuznetsov"
13-
- "@cjwagner"
14-
editor: TBD
12+
- stevekuznetsov
13+
- cjwagner
14+
editor: spiffxp
1515
creation-date: 2019-06-04
16-
last-updated: 2019-07-24
17-
status: implementable
18-
19-
latest-milestone: "0.0"
20-
stage: "alpha"
16+
last-updated: 2021-08-16
17+
status: implemented
18+
latest-milestone: v1.18
19+
stage: stable
20+
milestone:
21+
alpha: v1.15
22+
beta: v1.16
23+
stable: v1.18

0 commit comments

Comments
 (0)