Skip to content

Commit e5bdeb6

Browse files
committed
node: memmgr: fill gaps after port to latest KEP
Addressed some questions and information that were added while porting the KEP to latest template. Signed-off-by: Talor Itzhak <[email protected]>
1 parent 63dae8a commit e5bdeb6

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

keps/sig-node/1769-memory-manager/README.md

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ This can inform certain test coverage improvements that we want to do before
465465
extending the production code to implement this enhancement.
466466
-->
467467

468-
- `<package>`: `<date>` - `<test coverage>`
468+
- `k8s.io/kubernetes/pkg/kubelet/cm/memorymanager`: `20230928` - `81%`
469469

470470
##### Integration tests
471471

@@ -483,7 +483,7 @@ For Beta and GA, add links to added tests together with links to k8s-triage for
483483
https://storage.googleapis.com/k8s-triage/index.html
484484
-->
485485

486-
- <test>: <link to test coverage>
486+
Not Applicable.
487487

488488
##### e2e tests
489489

@@ -497,7 +497,7 @@ https://storage.googleapis.com/k8s-triage/index.html
497497
We expect no non-infra related flakes in the last month as a GA graduation criteria.
498498
-->
499499

500-
- <test>: <link to test coverage>
500+
- https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/memory_manager_test.go
501501

502502
### Graduation Criteria
503503

@@ -595,7 +595,7 @@ _This section must be completed when targeting alpha to a release._
595595

596596
###### How can this feature be enabled / disabled in a live cluster?
597597

598-
- [ ] Feature gate (also fill in values in `kep.yaml`)
598+
- [X] Feature gate (also fill in values in `kep.yaml`)
599599
- Feature gate name: MemoryManager
600600
- Components depending on the feature gate: kubelet
601601
- Will enabling / disabling the feature require downtime of the control
@@ -653,8 +653,9 @@ fields of API types, flags, etc.?**
653653
_This section must be completed when targeting beta graduation to a release._
654654

655655
###### How can an operator determine if the feature is in use by workloads?
656-
657-
The memory manager data will be available under pod resources API. When it configured with the static policy
656+
In order for workloads to request exclusive memory allocation, the pod QoS must be "guaranteed".
657+
The memory manager data will be available under pod resources API.
658+
When it is configured with the static policy,
658659
you will see memory related data during call to the pod resources API List method under the container.
659660

660661
###### How can someone using this feature know that it is working for their instance?
@@ -666,14 +667,13 @@ _This section must be completed when targeting beta graduation to a release._
666667

667668
*For a pod author:*
668669

669-
* Pod succeeded to start. You have two options to verify if containers pinned to the NUMA node
670+
* Pod succeeded to start. You have two options to verify if containers are pinned to the NUMA node
670671
- Via pod resources API, you will need to connect to grpc socket and get information from it, see [pod resource API doc page](https://kubernetes.io/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins/#monitoring-device-plugin-resources) for more information.
671672
- Checking the relevant container CGroup under the node.
672673

673674
* Pod failed to start because of the admission error.
674675

675-
To understand the reason you will need to check via pod resources API
676-
the amount of allocatable memory and memory reserved by containers.
676+
To understand the reason, you will need to check via pod resources API the amount of allocatable memory and memory reserved by containers.
677677

678678
###### What are the reasonable SLOs (Service Level Objectives) for the enhancement?
679679
This does not seem relevant to this feature.
@@ -750,6 +750,8 @@ Are there any tests that were run/should be run to understand performance charac
750750
and validate the declared limits?
751751
-->
752752

753+
No.
754+
753755
### Troubleshooting
754756

755757
The Troubleshooting section currently serves the `Playbook` role. We may consider

0 commit comments

Comments
 (0)