Skip to content

Commit e62baf2

Browse files
committed
Add small edits
1 parent d9012fd commit e62baf2

File tree

1 file changed

+4
-4
lines changed
  • keps/sig-storage/3751-volume-attributes-class

1 file changed

+4
-4
lines changed

keps/sig-storage/3751-volume-attributes-class/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ Items marked with (R) are required *prior to targeting to a milestone / release*
9090
- [ ] (R) Production readiness review completed
9191
- [ ] (R) Production readiness review approved
9292
- [X] "Implementation History" section is up-to-date for milestone
93-
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
93+
- [X] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
9494
- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
9595

9696
[kubernetes.io]: https://kubernetes.io/
@@ -679,7 +679,7 @@ We expect no non-infra related flakes in the last month as a GA graduation crite
679679

680680
#### Beta
681681

682-
- Beta in 1.31: Since this feature is an extension of the external-resizer/external-provisioner usage flow, we are going to move this to beta with enhanced e2e and test coverage. Test cases are covered in sessions above: ``e2e tests``, ``Integration tests`` etc.
682+
- Beta in 1.31: Since this feature is an extension of the external-resizer/external-provisioner usage flow, we are going to move this to beta with enhanced e2e and test coverage. Test cases are covered in sessions above: ``e2e tests``, ``Integration tests`` etc. Controllers will handle VolumeAttributeClass feature gates being on by default, but beta API itself being disabled on cluster by default.
683683
- Involve 3 different CSI drivers to participate in testing
684684
- Stress test before GA
685685

@@ -795,12 +795,12 @@ These goals will help you determine what you need to measure (SLIs) in the next
795795
question.
796796
-->
797797

798-
- Ratio of `controller_modify_volume_errors_total`/`controller_modify_volume_total` <= 1%
798+
- Ratio of `controller_modify_volume_errors_total`/`controller_modify_volume_total` <= 1%. (Exclude errors with `UNAVAILABLE` code which indicate some quota has been exhausted.)
799799
- CreateVolume `csi_sidecar_operations_seconds_sum` does not increase by more than 5% when feature flags are enabled.
800800

801801
###### What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?
802802

803-
- [ ] Metrics
803+
- [X] Metrics
804804
- Metric name: `controller_modify_volume_total` and `controller_modify_volume_errors_total`
805805
- [Optional] Aggregation method:
806806
- Components exposing the metric: external-resizer

0 commit comments

Comments
 (0)