Skip to content

Commit e97778a

Browse files
committed
KEP-4438: rename gate and update milestones
Signed-off-by: Matthias Bertschy <[email protected]>
1 parent a51e5b8 commit e97778a

File tree

2 files changed

+17
-8
lines changed

2 files changed

+17
-8
lines changed

keps/sig-node/4438-sidecar-restart-termination/README.md renamed to keps/sig-node/4438-container-restart-termination/README.md

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,15 @@ the restart during Pod termination.
207207
List the specific goals of the KEP. What is it trying to achieve? How will we
208208
know that this has succeeded?
209209
-->
210+
The following behaviors should be maintained during pod termination:
211+
- sidecar containers restarting
212+
- liveness, readiness and startup probing
213+
- container lifecycle hooks running
214+
- service account token rotation
215+
- secret and configmap volume updates
216+
217+
Also, container termination should be non-blocking, which will fix issue [#121398](https://github.com/kubernetes/kubernetes/issues/121398)
218+
a container cannot restart when there is any terminating container in the same pod.
210219

211220
### Non-Goals
212221

@@ -471,7 +480,7 @@ in back-to-back releases.
471480
#### Alpha
472481

473482
- Allow sidecar containers to restart during the shutdown of the Pod.
474-
- Enable `livenessProbe` and `startupProbe` during the shutdown of the Pod for sidecar containers that restart.
483+
- Enable `livenessProbe`, `readinessProbe` and `startupProbe` during the shutdown of the Pod for sidecar containers that restart.
475484
- Enable `postStart` and `preStop` hooks during the shutdown of the Pod for sidecar containers that restart.
476485

477486
#### Beta
@@ -559,7 +568,7 @@ well as the [existing list] of feature gates.
559568
-->
560569

561570
- [X] Feature gate (also fill in values in `kep.yaml`)
562-
- Feature gate name: SidecarContainerRestartDuringTermination
571+
- Feature gate name: RestartContainerDuringTermination
563572
- Components depending on the feature gate:
564573
- kubelet
565574
- [ ] Other

keps/sig-node/4438-sidecar-restart-termination/kep.yaml renamed to keps/sig-node/4438-container-restart-termination/kep.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ participating-sigs:
88
- sig-scheduler
99
status: implementable
1010
creation-date: 2024-01-25
11-
last-updated: 2024-02-02
11+
last-updated: 2024-05-22
1212
reviewers:
1313
- "@mrunalp" # overall
1414
- "@ahg-g" # SIG Scheduling
@@ -27,18 +27,18 @@ stage: alpha
2727
# The most recent milestone for which work toward delivery of this KEP has been
2828
# done. This can be the current (upcoming) milestone, if it is being actively
2929
# worked on.
30-
latest-milestone: "v1.30"
30+
latest-milestone: "v1.31"
3131

3232
# The milestone at which this feature was, or is targeted to be, at each stage.
3333
milestone:
34-
alpha: "v1.30"
35-
beta: "v1.31"
36-
stable: "v1.32"
34+
alpha: "v1.31"
35+
beta: "v1.32"
36+
stable: "v1.33"
3737

3838
# The following PRR answers are required at alpha release
3939
# List the feature gate name and the components for which it must be enabled
4040
feature-gates:
41-
- name: SidecarContainerRestartDuringTermination
41+
- name: RestartContainerDuringTermination
4242
components:
4343
- kubelet
4444
disable-supported: true

0 commit comments

Comments
 (0)