File tree Expand file tree Collapse file tree 1 file changed +8
-7
lines changed
keps/sig-node/3288-separate-stdout-from-stderr Expand file tree Collapse file tree 1 file changed +8
-7
lines changed Original file line number Diff line number Diff line change @@ -178,10 +178,9 @@ retrieve certain log stream of a container, so it is great to implement this lon
178
178
179
179
### Non-Goals
180
180
181
- <!--
182
- What is out of scope for this KEP? Listing non-goals helps to focus discussion
183
- and make progress.
184
- -->
181
+ - Supporting the combination of a specific ` Stream ` (stdout or stderr) and ` TailLines ` in the first iteration. However,
182
+ if ` Stream ` is set to ` all ` , both ` Stream ` and ` TailLines ` can be specified together.
183
+ - Implementing a new log format
185
184
186
185
## Proposal
187
186
@@ -246,11 +245,13 @@ If users run `kubectl logs --stream=stderr --tail=2 pod`, kubelet would only ret
246
245
err2
247
246
```
248
247
249
- This approach is more efficient, as kubelet only needs to parse a deterministic number of lines of log lines once
248
+ This approach is more efficient, as kubelet only needs to parse a deterministic number of log lines once,
250
249
rather than potentially all of them. However, this may go against users' expectations and could lead to confusion.
251
250
252
- Taking all these considerations into account, I propose that we do not support the combination of ` Stream ` and ` TailLines `
253
- in the first iteration.
251
+ Taking all these considerations into account, I propose that we do not support the combination of specific ` Stream `
252
+ and ` TailLines ` in the first iteration.
253
+ Additionally, the apiserver should validate the ` PodLogOptions ` to ensure that a specific ` Stream ` and ` TailLines `
254
+ are mutually exclusive.
254
255
255
256
### Risks and Mitigations
256
257
You can’t perform that action at this time.
0 commit comments