Skip to content

Commit e9bec8c

Browse files
committed
address comments
Signed-off-by: Jian Zeng <[email protected]>
1 parent cda758d commit e9bec8c

File tree

1 file changed

+8
-7
lines changed
  • keps/sig-node/3288-separate-stdout-from-stderr

1 file changed

+8
-7
lines changed

keps/sig-node/3288-separate-stdout-from-stderr/README.md

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -178,10 +178,9 @@ retrieve certain log stream of a container, so it is great to implement this lon
178178

179179
### Non-Goals
180180

181-
<!--
182-
What is out of scope for this KEP? Listing non-goals helps to focus discussion
183-
and make progress.
184-
-->
181+
- Supporting the combination of a specific `Stream`(stdout or stderr) and `TailLines` in the first iteration. However,
182+
if `Stream` is set to `all`, both `Stream` and `TailLines` can be specified together.
183+
- Implementing a new log format
185184

186185
## Proposal
187186

@@ -246,11 +245,13 @@ If users run `kubectl logs --stream=stderr --tail=2 pod`, kubelet would only ret
246245
err2
247246
```
248247

249-
This approach is more efficient, as kubelet only needs to parse a deterministic number of lines of log lines once
248+
This approach is more efficient, as kubelet only needs to parse a deterministic number of log lines once,
250249
rather than potentially all of them. However, this may go against users' expectations and could lead to confusion.
251250

252-
Taking all these considerations into account, I propose that we do not support the combination of `Stream` and `TailLines`
253-
in the first iteration.
251+
Taking all these considerations into account, I propose that we do not support the combination of specific `Stream`
252+
and `TailLines`in the first iteration.
253+
Additionally, the apiserver should validate the `PodLogOptions` to ensure that a specific `Stream` and `TailLines`
254+
are mutually exclusive.
254255

255256
### Risks and Mitigations
256257

0 commit comments

Comments
 (0)