Skip to content

Commit eb2eda9

Browse files
committed
node: KEP- 2902: Updates for Beta graduation
Signed-off-by: Swati Sehgal <[email protected]>
1 parent e49b717 commit eb2eda9

File tree

3 files changed

+22
-8
lines changed

3 files changed

+22
-8
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
kep-number: 2902
22
alpha:
33
approver: "@johnbelamaric"
4+
beta:
5+
approver: "@johnbelamaric"

keps/sig-node/2902-cpumanager-distribute-cpus-policy-option/README.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ When enabled, this will trigger the `CPUManager` to evenly distribute CPUs acros
7575
### Risks and Mitigations
7676

7777
The risks of adding this new feature are quite low.
78-
It is isolated to a specific policy option within the `CPUManager`, and is protected both by the option itself, as well as the `CPUManagerPolicyAlphaOptions` feature gate (which is disabled by default).
78+
It is isolated to a specific policy option within the `CPUManager`, and is protected both by the option itself, as well as the `CPUManagerPolicyBetaOptions` feature gate (which is disabled by default).
7979

8080
| Risk | Impact | Mitigation |
8181
| -------------------------------------------------| -------| ---------- |
@@ -149,7 +149,9 @@ No changes needed
149149
###### How can this feature be enabled / disabled in a live cluster?
150150

151151
- [X] Feature gate (also fill in values in `kep.yaml`)
152+
- Feature gate name: `CPUManagerPolicyOptions`
152153
- Feature gate name: `CPUManagerPolicyAlphaOptions`
154+
- Feature gate name: `CPUManagerPolicyBetaOptions`
153155
- Components depending on the feature gate: `kubelet`
154156
- [X] Change the kubelet configuration to set a `CPUManager` policy of `static` and a `CPUManager` policy option of `distribute-cpus-across-numa`
155157
- Will enabling / disabling the feature require downtime of the control
@@ -161,14 +163,14 @@ No changes needed
161163
###### Does enabling the feature change any default behavior?
162164

163165
No. In order to trigger any of the new logic, three things have to be true:
164-
1. The `CPUManagerPolicyAlphaOptions` feature gate must be enabled
166+
1. The `CPUManagerPolicyBetaOptions` feature gate must be enabled
165167
1. The `static` `CPUManager` policy must be selected
166168
1. The new `distribute-cpus-across-numa` policy option must be selected
167169

168170
###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?
169171

170172
Yes, the feature can be disabled by either:
171-
1. Disabling the `CPUManagerPolicyAlphaOptions` feature gate
173+
1. Disabling the `CPUManagerPolicyBetaOptions` feature gate
172174
1. Switching the `CPUManager` policy to `none`
173175
1. Removing `distribute-cpus-across-numa` from the list of `CPUManager` policy options
174176

@@ -255,3 +257,4 @@ No, the algorithm will run on a single `goroutine` with minimal memory requireme
255257
- 2021-08-30: Updates to fill out more sections, answer PRR questions
256258
- 2021-09-08: Change feature gate from `CPUManagerPolicyOptions` to `CPUManagerPolicyExperimentalOptions`
257259
- 2021-10-11: Change feature gate from `CPUManagerPolicyExperimentalOptions` to `CPUManagerPolicyAlphaOptions`
260+
- 2025-01-30: KEP update for Beta graduation of the policy option

keps/sig-node/2902-cpumanager-distribute-cpus-policy-option/kep.yaml

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,36 +2,45 @@ title: CPUManager Policy Option to Distribute CPUs Across NUMA Nodes Instead of
22
kep-number: 2902
33
authors:
44
- "@klueska"
5+
- "@swatisehgal" # For Beta graduation
56
owning-sig: sig-node
67
participating-sigs: []
78
status: implementable
89
creation-date: "2021-08-26"
10+
last-updated: "2025-01-31"
911
reviewers:
10-
- "@fromani"
12+
- "@ffromani"
1113
approvers:
1214
- "@sig-node-tech-leads"
1315
see-also:
1416
- "keps/sig-node/2625-cpumanager-policies-thread-placement"
17+
- "keps/sig-node/3545-improved-multi-numa-alignment/"
18+
- "keps/sig-node/4176-cpumanager-spread-cpus-preferred-policy/"
19+
- "keps/sig-node/4540-strict-cpu-reservation"
20+
- "keps/sig-node/4622-topologymanager-max-allowable-numa-nodes/"
21+
- "keps/sig-node/4800-cpumanager-split-uncorecache/"
1522
replaces: []
1623

1724
# The target maturity stage in the current dev cycle for this KEP.
18-
stage: alpha
25+
stage: beta
1926

2027
# The most recent milestone for which work toward delivery of this KEP has been
2128
# done. This can be the current (upcoming) milestone, if it is being actively
2229
# worked on.
23-
latest-milestone: "v1.23"
30+
latest-milestone: "v1.33"
2431

2532
# The milestone at which this feature was, or is targeted to be, at each stage.
2633
milestone:
2734
alpha: "v1.23"
28-
beta: "v1.24"
29-
stable: "v1.25"
35+
beta: "v1.33"
36+
stable: "v1.35"
3037

3138
# The following PRR answers are required at alpha release
3239
# List the feature gate name and the components for which it must be enabled
3340
feature-gates:
41+
- name: "CPUManagerPolicyOptions"
3442
- name: "CPUManagerPolicyAlphaOptions"
43+
- name: "CPUManagerPolicyBetaOptions"
3544
components:
3645
- kubelet
3746
disable-supported: true

0 commit comments

Comments
 (0)