Skip to content

Commit eec531d

Browse files
committed
Add template for deprecation feature
1 parent ed5d0b1 commit eec531d

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

api/approval.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ type PRRApproval struct {
4141
Beta *PRRMilestone `json:"beta" yaml:"beta,omitempty"`
4242
Stable *PRRMilestone `json:"stable" yaml:"stable,omitempty"`
4343
Deprecated *PRRMilestone `json:"deprecated" yaml:"deprecated,omitempty"`
44-
Removed *PRRMilestone `json:"removed", yaml:"removed,omitempty"`
44+
Removed *PRRMilestone `json:"removed" yaml:"removed,omitempty"`
45+
Disabled *PRRMilestone `json:"disabled" yaml:"disabled,omitempty"`
4546

4647
// TODO(api): Move to separate struct for handling document parsing
4748
Error error `json:"-" yaml:"-"`

api/proposal.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,18 @@ const (
3636
AlphaStage Stage = "alpha"
3737
BetaStage Stage = "beta"
3838
StableStage Stage = "stable"
39+
Deprecated Stage = "deprecated"
40+
Disabled Stage = "disabled"
41+
Removed Stage = "removed"
3942
)
4043

4144
var ValidStages = []Stage{
4245
AlphaStage,
4346
BetaStage,
4447
StableStage,
48+
Deprecated,
49+
Disabled,
50+
Removed,
4551
}
4652

4753
func (s Stage) IsValid() error {
@@ -138,6 +144,7 @@ type Milestone struct {
138144
Stable string `json:"stable" yaml:"stable"`
139145
Deprecated string `json:"deprecated" yaml:"deprecated,omitempty"`
140146
Removed string `json:"removed" yaml:"removed,omitempty"`
147+
Disabled string `json:"disabled" yaml:"disabled,omitempty"`
141148
}
142149

143150
type FeatureGate struct {

keps/NNNN-kep-template/kep.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ replaces:
2222
- "/keps/sig-ccc/3456-replaced-kep"
2323

2424
# The target maturity stage in the current dev cycle for this KEP.
25+
# If the purpose of this KEP is to deprecate a user-visible feature
26+
# and a Deprecated feature gates are added, they should be deprecated|disabled|removed.
2527
stage: alpha|beta|stable
2628

2729
# The most recent milestone for which work toward delivery of this KEP has been

0 commit comments

Comments
 (0)