Skip to content

Commit f0d90bd

Browse files
richabankerHan Kang
andcommitted
Update keps/sig-api-machinery/4020-unknown-version-interoperability-proxy/README.md
Co-authored-by: Han Kang <[email protected]>
1 parent 0e699f7 commit f0d90bd

File tree

1 file changed

+7
-10
lines changed
  • keps/sig-api-machinery/4020-unknown-version-interoperability-proxy

1 file changed

+7
-10
lines changed

keps/sig-api-machinery/4020-unknown-version-interoperability-proxy/README.md

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ How the masterlease reconciler will be used is as follows:
328328

329329
3. We will also expose the IP and port information of the kube-apiservers as annotations in APIserver identity lease object for visibility/debugging purposes
330330

331-
4. We will also use an egress dialer for network connections made to peer kube-apiservers. For this, will create a new type for the network context to be used for peer kube-apiserver connections ([xref](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/apis/apiserver/types.go#L55-L71))
331+
4. We will also use an egress dialer for network connections made to peer kube-apiservers. For this, will create a new type for the network context to be used for peer kube-apiserver connections ([xref](https://github.com/kubernetes/kubernetes/blob/release-1.27/staging/src/k8s.io/apiserver/pkg/apis/apiserver/types.go#L56-L71))
332332

333333
#### Proxy transport between apiservers and authn
334334

@@ -574,12 +574,6 @@ well as the [existing list] of feature gates.
574574
- [x] Feature gate (also fill in values in `kep.yaml`)
575575
- Feature gate name: UnknownVersionInteroperabilityProxy
576576
- Components depending on the feature gate: kube-apiserver
577-
- [ ] Other
578-
- Describe the mechanism:
579-
- Will enabling / disabling the feature require downtime of the control
580-
plane?
581-
- Will enabling / disabling the feature require downtime or reprovisioning
582-
of a node?
583577

584578
###### Does enabling the feature change any default behavior?
585579

@@ -691,7 +685,7 @@ logs or events for this purpose.
691685
-->
692686

693687
The following metrics could be used to see if the feature is in use:
694-
- kubernetes_uvip_count
688+
- kubernetes_uvip_total
695689

696690
###### How can someone using this feature know that it is working for their instance?
697691

@@ -704,7 +698,7 @@ and operation of this feature.
704698
Recall that end users cannot usually observe component logs or access metrics.
705699
-->
706700

707-
- Metrics like kubernetes_uvip_count can be used to check how many requests were proxied to remote apiserver
701+
- Metrics like kubernetes_uvip_total can be used to check how many requests were proxied to remote apiserver
708702

709703
###### What are the reasonable SLOs (Service Level Objectives) for the enhancement?
710704

@@ -723,6 +717,7 @@ These goals will help you determine what you need to measure (SLIs) in the next
723717
question.
724718
-->
725719

720+
None have been identified.
726721

727722
###### What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?
728723

@@ -731,7 +726,7 @@ Pick one more of these and delete the rest.
731726
-->
732727

733728
- [X] Metrics
734-
- Metric name: `kubernetes_uvip_count`
729+
- Metric name: `kubernetes_uvip_total`
735730
- Components exposing the metric: kube-apiserver
736731

737732
###### Are there any missing metrics that would be useful to have to improve observability of this feature?
@@ -843,6 +838,8 @@ Think about adding additional work or introducing new steps in between
843838
[existing SLIs/SLOs]: https://git.k8s.io/community/sig-scalability/slos/slos.md#kubernetes-slisslos
844839
-->
845840

841+
When handling a request in the handler chain of the kube-aggregator, the StorageVersion informer will be used to look up which API servers can serve the requested resource.
842+
846843
###### Will enabling / using this feature result in non-negligible increase of resource usage (CPU, RAM, disk, IO, ...) in any components?
847844

848845
<!--

0 commit comments

Comments
 (0)