Skip to content

Commit f425f4b

Browse files
committed
fixup! KEP-3221: update kep
Signed-off-by: Nabarun Pal <[email protected]>
1 parent 8cac6ff commit f425f4b

File tree

1 file changed

+11
-10
lines changed
  • keps/sig-auth/3221-structured-authorization-configuration

1 file changed

+11
-10
lines changed

keps/sig-auth/3221-structured-authorization-configuration/README.md

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -210,8 +210,9 @@ will not be able to start. This can be mitigated by fixing the malformed values.
210210

211211
We would like to introduce a structured file format which allows authorization
212212
to be configured using a flag (`--authorization-config-file`) which accepts a
213-
path to a file on the disk. This feature can be enabled or disabled by the
214-
explicit feature flag `AuthorizationConfigFromFile`.
213+
path to a file on the disk. Setting both `--authorization-config-file` and
214+
configuring an authorization webhook will not be allowed. If the user does that,
215+
there will be an error and API Server would exit right away.
215216

216217
The proposed structure is illustrated below:
217218

@@ -321,15 +322,14 @@ flag is not supplied. While configuring authorization modes using the file confi
321322
the version supported by a webhook has to be mentioned using a required field
322323
`subjectAccessReviewVersion`.
323324

324-
The code path for enabling the above will only be triggered if the feature flag will
325-
be enabled until the time the feature flag is removed and configuring authorizer
326-
through a file becomes GA.
327-
328325
The user can define a CEL expression to determine whether a request needs to dispatched
329326
to the authz webhook for which the expression has been defined. The user would have access
330327
to a `request` variable containing a `SubjectAccessReview` object in the version specified
331328
by `subjectAccessReviewVersion`.
332329

330+
The code path for enabling the above will only be triggered if the feature flag will
331+
be enabled until the time the feature flag is removed and configuring authorizer
332+
through a file becomes GA.
333333

334334
### Monitoring
335335

@@ -340,6 +340,7 @@ We will add the following 4 metrics:
340340
This will be incremented on round-trip of an authorizer. It will track total
341341
authorization decision invocations across the following labels.
342342

343+
Labels {along with possible values}:
343344
- `mode` {RBAC, Node, Webhook}
344345
- `decision` {Allow, Deny, NoOpinion}
345346

@@ -352,12 +353,12 @@ total invocation counts across the following labels.
352353
- `code` {2xx, 4xx, 5xx}
353354
- `decision` {Allow, Deny, NoOpinion}
354355

355-
3. `apiserver_authorization_step_webhook_duration_seconds`
356+
3. `apiserver_authorization_step_webhook_duration_total_seconds`
356357

357-
This metric will track the average latency
358+
This metric will track the total round trip time of the requests to the webhook.
358359

359360
Labels {along with possible values}:
360-
- `server`
361+
- `name`
361362
- `code` {2xx, 4xx, 5xx}
362363
- `decision` {Allow, Deny, NoOpinion}
363364

@@ -367,7 +368,7 @@ This metric will be incremented when a webhook returns a 4xx or 5xx (erroneous)
367368

368369
Labels {along with possible values}:
369370

370-
- server
371+
- `name`
371372
- `code` {4xx, 5xx}
372373
- `decision` {Deny, NoOpinion}
373374

0 commit comments

Comments
 (0)