@@ -210,8 +210,9 @@ will not be able to start. This can be mitigated by fixing the malformed values.
210
210
211
211
We would like to introduce a structured file format which allows authorization
212
212
to be configured using a flag (`--authorization-config-file`) which accepts a
213
- path to a file on the disk. This feature can be enabled or disabled by the
214
- explicit feature flag `AuthorizationConfigFromFile`.
213
+ path to a file on the disk. Setting both `--authorization-config-file` and
214
+ configuring an authorization webhook will not be allowed. If the user does that,
215
+ there will be an error and API Server would exit right away.
215
216
216
217
The proposed structure is illustrated below :
217
218
@@ -321,15 +322,14 @@ flag is not supplied. While configuring authorization modes using the file confi
321
322
the version supported by a webhook has to be mentioned using a required field
322
323
` subjectAccessReviewVersion` .
323
324
324
- The code path for enabling the above will only be triggered if the feature flag will
325
- be enabled until the time the feature flag is removed and configuring authorizer
326
- through a file becomes GA.
327
-
328
325
The user can define a CEL expression to determine whether a request needs to dispatched
329
326
to the authz webhook for which the expression has been defined. The user would have access
330
327
to a `request` variable containing a `SubjectAccessReview` object in the version specified
331
328
by `subjectAccessReviewVersion`.
332
329
330
+ The code path for enabling the above will only be triggered if the feature flag will
331
+ be enabled until the time the feature flag is removed and configuring authorizer
332
+ through a file becomes GA.
333
333
334
334
# ## Monitoring
335
335
@@ -340,6 +340,7 @@ We will add the following 4 metrics:
340
340
This will be incremented on round-trip of an authorizer. It will track total
341
341
authorization decision invocations across the following labels.
342
342
343
+ Labels {along with possible values} :
343
344
- ` mode` {RBAC, Node, Webhook}
344
345
- ` decision` {Allow, Deny, NoOpinion}
345
346
@@ -352,12 +353,12 @@ total invocation counts across the following labels.
352
353
- ` code` {2xx, 4xx, 5xx}
353
354
- ` decision` {Allow, Deny, NoOpinion}
354
355
355
- 3. `apiserver_authorization_step_webhook_duration_seconds `
356
+ 3. `apiserver_authorization_step_webhook_duration_total_seconds `
356
357
357
- This metric will track the average latency
358
+ This metric will track the total round trip time of the requests to the webhook.
358
359
359
360
Labels {along with possible values} :
360
- - ` server `
361
+ - ` name `
361
362
- ` code` {2xx, 4xx, 5xx}
362
363
- ` decision` {Allow, Deny, NoOpinion}
363
364
@@ -367,7 +368,7 @@ This metric will be incremented when a webhook returns a 4xx or 5xx (erroneous)
367
368
368
369
Labels {along with possible values} :
369
370
370
- - server
371
+ - ` name `
371
372
- ` code` {4xx, 5xx}
372
373
- ` decision` {Deny, NoOpinion}
373
374
0 commit comments