Skip to content

Commit f451a19

Browse files
authored
Merge pull request #4442 from mimowo/pod-failure-policy-kep-update-deprecatoin
KEP-3329 pod failure policy update for 1.30
2 parents 10f8785 + b38494d commit f451a19

File tree

1 file changed

+9
-9
lines changed
  • keps/sig-apps/3329-retriable-and-non-retriable-failures

1 file changed

+9
-9
lines changed

keps/sig-apps/3329-retriable-and-non-retriable-failures/README.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1193,10 +1193,12 @@ feature documentation to explain this change. In particular, we are going to
11931193
provide a list of example scenarios impacted by this change, including:
11941194
invalid image reference, invalid config map reference.
11951195

1196-
One release after the `PodDisruptionCondition` feature gate graduates to GA
1197-
we plan to simplify Job controller to consider as failed (and count as such)
1198-
pods which are in terminal phase regardless of the fact if the `podFailurePolicy`
1199-
is specified (see [Deprecation](#deprecation)).
1196+
We considered to simplify Job controller to count as failed only pods which
1197+
are in terminal phase regardless of the fact if the `podFailurePolicy`.
1198+
However, we will not do it as discussed on the dedicated issue
1199+
[Job controller should wait for Pods to be in a terminal phase before considering them failed or succeeded](https://github.com/kubernetes/kubernetes/issues/116858),
1200+
because this would not only be a cleanup, but also change of the current semantic
1201+
when pod failure policy is not used. The current semantic matches the expectations.
12001202

12011203
### Risks and Mitigations
12021204

@@ -1741,12 +1743,13 @@ Third iteration (1.28):
17411743
Fourth iteration (1.29):
17421744
- Fix the [Pod Garbage collector fails to clean up PODs from nodes that are not running anymore](https://github.com/kubernetes/kubernetes/issues/118261).
17431745
by withdrawing from SSA in the k8s controllers which were adding the `DisruptionTarget` condition.
1744-
We will reconsider returning to SSA if the issue is fixed.
1746+
We will reconsider returning to SSA if the issue is fixed, but we consider the
1747+
transition as a technical detail, not impacting the API, which can be done
1748+
independently of the KEP graduation cycles.
17451749

17461750
#### GA
17471751

17481752
- Address reviews and bug reports from Beta users
1749-
- Reconsider returning to SSA if the issue [#113482](https://github.com/kubernetes/kubernetes/issues/113482) is fixed
17501753
- Write a blog post about the feature
17511754
- Graduate e2e tests as conformance tests
17521755
- Lock the `PodDisruptionConditions` and `JobPodFailurePolicy` feature-gates
@@ -1768,9 +1771,6 @@ in back-to-back releases.
17681771

17691772
In GA+1 release:
17701773
- Modify the code to ignore the `PodDisruptionConditions` and `JobPodFailurePolicy` feature gates
1771-
- Simplify the Job controller to wait for pods to terminate before counting them
1772-
as failed or matching against the pod failure policy, regardless if the pod
1773-
failure policy is specified (see: [Job controller should wait for Pods to terminate to match the failure policy](https://github.com/kubernetes/kubernetes/issues/113855)).
17741774

17751775
In GA+2 release:
17761776
- Remove the `PodDisruptionConditions` and `JobPodFailurePolicy` feature gates

0 commit comments

Comments
 (0)