You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: keps/sig-apps/3329-retriable-and-non-retriable-failures/README.md
+9-9Lines changed: 9 additions & 9 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1193,10 +1193,12 @@ feature documentation to explain this change. In particular, we are going to
1193
1193
provide a list of example scenarios impacted by this change, including:
1194
1194
invalid image reference, invalid config map reference.
1195
1195
1196
-
One release after the `PodDisruptionCondition` feature gate graduates to GA
1197
-
we plan to simplify Job controller to consider as failed (and count as such)
1198
-
pods which are in terminal phase regardless of the fact if the `podFailurePolicy`
1199
-
is specified (see [Deprecation](#deprecation)).
1196
+
We considered to simplify Job controller to count as failed only pods which
1197
+
are in terminal phase regardless of the fact if the `podFailurePolicy`.
1198
+
However, we will not do it as discussed on the dedicated issue
1199
+
[Job controller should wait for Pods to be in a terminal phase before considering them failed or succeeded](https://github.com/kubernetes/kubernetes/issues/116858),
1200
+
because this would not only be a cleanup, but also change of the current semantic
1201
+
when pod failure policy is not used. The current semantic matches the expectations.
1200
1202
1201
1203
### Risks and Mitigations
1202
1204
@@ -1741,12 +1743,13 @@ Third iteration (1.28):
1741
1743
Fourth iteration (1.29):
1742
1744
- Fix the [Pod Garbage collector fails to clean up PODs from nodes that are not running anymore](https://github.com/kubernetes/kubernetes/issues/118261).
1743
1745
by withdrawing from SSA in the k8s controllers which were adding the `DisruptionTarget` condition.
1744
-
We will reconsider returning to SSA if the issue is fixed.
1746
+
We will reconsider returning to SSA if the issue is fixed, but we consider the
1747
+
transition as a technical detail, not impacting the API, which can be done
1748
+
independently of the KEP graduation cycles.
1745
1749
1746
1750
#### GA
1747
1751
1748
1752
- Address reviews and bug reports from Beta users
1749
-
- Reconsider returning to SSA if the issue [#113482](https://github.com/kubernetes/kubernetes/issues/113482) is fixed
1750
1753
- Write a blog post about the feature
1751
1754
- Graduate e2e tests as conformance tests
1752
1755
- Lock the `PodDisruptionConditions` and `JobPodFailurePolicy` feature-gates
@@ -1768,9 +1771,6 @@ in back-to-back releases.
1768
1771
1769
1772
In GA+1 release:
1770
1773
- Modify the code to ignore the `PodDisruptionConditions` and `JobPodFailurePolicy` feature gates
1771
-
- Simplify the Job controller to wait for pods to terminate before counting them
1772
-
as failed or matching against the pod failure policy, regardless if the pod
1773
-
failure policy is specified (see: [Job controller should wait for Pods to terminate to match the failure policy](https://github.com/kubernetes/kubernetes/issues/113855)).
1774
1774
1775
1775
In GA+2 release:
1776
1776
- Remove the `PodDisruptionConditions` and `JobPodFailurePolicy` feature gates
0 commit comments