Skip to content

Commit f8c7a78

Browse files
committed
Promote to GA in 1.34
1 parent 205cf49 commit f8c7a78

File tree

3 files changed

+27
-37
lines changed

3 files changed

+27
-37
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
kep-number: 5080
22
beta:
33
approver: "@jpbetz"
4+
stable:
5+
approver: "@jpbetz"

keps/sig-api-machinery/5080-ordered-namespace-deletion/README.md

Lines changed: 22 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
- [Integration tests](#integration-tests)
2626
- [e2e tests](#e2e-tests)
2727
- [Graduation Criteria](#graduation-criteria)
28-
- [Alpha](#alpha)
2928
- [Beta](#beta)
3029
- [GA](#ga)
3130
- [Upgrade / Downgrade Strategy](#upgrade--downgrade-strategy)
@@ -355,24 +354,17 @@ in back-to-back releases.
355354
- Address feedback on usage/changed behavior, provided on GitHub issues
356355
- Deprecate the flag
357356
-->
358-
#### Alpha
357+
#### Beta
359358

360359
- Feature implemented behind a feature flag
361360
- Initial e2e tests completed and enabled
362-
363-
#### Beta
364-
365-
- Gather feedback from developers and surveys
366361
- Complete features specified in the KEP
367362
- Proper metrics added
368363
- Additional tests are in Testgrid and linked in KEP
369364

370365
#### GA
371366

372-
- N examples of real-world usage
373-
- N installs
374-
- More rigorous forms of testing—e.g., downgrade tests and scalability tests
375-
- Allowing time for feedback
367+
- Related [CVE](https://github.com/kubernetes/kubernetes/issues/126587) has been mitigated
376368
- Conformance tests
377369

378370
**Note:** Generally we also wait at least two releases between beta and
@@ -451,13 +443,15 @@ feature flags will be enabled on some API servers and not others during the
451443
rollout. Similarly, consider large clusters and how enablement/disablement
452444
will rollout across nodes.
453445
-->
446+
This feature should not impact rollout.
454447

455448
###### What specific metrics should inform a rollback?
456449

457450
<!--
458451
What signals should users be paying attention to when the feature is young
459452
that might indicate a serious problem?
460453
-->
454+
N/A
461455

462456
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
463457

@@ -466,12 +460,14 @@ Describe manual testing that was done and the outcomes.
466460
Longer term, we may want to require automated upgrade/rollback tests, but we
467461
are missing a bunch of machinery and tooling and can't do that now.
468462
-->
463+
N/A
469464

470465
###### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?
471466

472467
<!--
473468
Even if applying deprecation policies, they may still surprise some users.
474469
-->
470+
No.
475471

476472
### Monitoring Requirements
477473

@@ -489,6 +485,7 @@ Ideally, this should be a metric. Operations against the Kubernetes API (e.g.,
489485
checking if there are objects with field X set) may be a last resort. Avoid
490486
logs or events for this purpose.
491487
-->
488+
Check if the feature gate is enabled. The feature is a security fix which should not be user detectable.
492489

493490
###### How can someone using this feature know that it is working for their instance?
494491

@@ -501,13 +498,7 @@ and operation of this feature.
501498
Recall that end users cannot usually observe component logs or access metrics.
502499
-->
503500

504-
- [ ] Events
505-
- Event Reason:
506-
- [ ] API .status
507-
- Condition name:
508-
- Other field:
509-
- [ ] Other (treat as last resort)
510-
- Details:
501+
N/A
511502

512503
###### What are the reasonable SLOs (Service Level Objectives) for the enhancement?
513504

@@ -525,26 +516,22 @@ high level (needs more precise definitions) those may be things like:
525516
These goals will help you determine what you need to measure (SLIs) in the next
526517
question.
527518
-->
519+
The feature only affect namespace deletion and should not affect existing SLOs.
528520

529521
###### What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?
530522

531523
<!--
532524
Pick one more of these and delete the rest.
533525
-->
534-
535-
- [ ] Metrics
536-
- Metric name:
537-
- [Optional] Aggregation method:
538-
- Components exposing the metric:
539-
- [ ] Other (treat as last resort)
540-
- Details:
526+
The error or blocker will be updated to namespace status subresource to follow the existing pattern.
541527

542528
###### Are there any missing metrics that would be useful to have to improve observability of this feature?
543529

544530
<!--
545531
Describe the metrics themselves and the reasons why they weren't added (e.g., cost,
546532
implementation difficulties, etc.).
547533
-->
534+
Namespace status will be used to capture the possible error or blockers while deletion.
548535

549536
### Dependencies
550537

@@ -568,7 +555,7 @@ and creating new ones, as well as about cluster-level services (e.g. DNS):
568555
- Impact of its outage on the feature:
569556
- Impact of its degraded performance or high-error rates on the feature:
570557
-->
571-
558+
No.
572559
### Scalability
573560

574561
<!--
@@ -595,6 +582,7 @@ Focusing mostly on:
595582
- periodic API calls to reconcile state (e.g. periodic fetching state,
596583
heartbeats, leader election, etc.)
597584
-->
585+
No.
598586

599587
###### Will enabling / using this feature result in introducing new API types?
600588

@@ -604,15 +592,15 @@ Describe them, providing:
604592
- Supported number of objects per cluster
605593
- Supported number of objects per namespace (for namespace-scoped objects)
606594
-->
607-
595+
No.
608596
###### Will enabling / using this feature result in any new calls to the cloud provider?
609597

610598
<!--
611599
Describe them, providing:
612600
- Which API(s):
613601
- Estimated increase:
614602
-->
615-
603+
No.
616604
###### Will enabling / using this feature result in increasing size or count of the existing API objects?
617605

618606
<!--
@@ -621,7 +609,7 @@ Describe them, providing:
621609
- Estimated increase in size: (e.g., new annotation of size 32B)
622610
- Estimated amount of new objects: (e.g., new Object X for every existing Pod)
623611
-->
624-
612+
No.
625613
###### Will enabling / using this feature result in increasing time taken by any operations covered by existing SLIs/SLOs?
626614

627615
<!--
@@ -632,7 +620,7 @@ Think about adding additional work or introducing new steps in between
632620
633621
[existing SLIs/SLOs]: https://git.k8s.io/community/sig-scalability/slos/slos.md#kubernetes-slisslos
634622
-->
635-
623+
No.
636624
###### Will enabling / using this feature result in non-negligible increase of resource usage (CPU, RAM, disk, IO, ...) in any components?
637625

638626
<!--
@@ -644,7 +632,7 @@ This through this both in small and large cases, again with respect to the
644632
645633
[supported limits]: https://git.k8s.io/community//sig-scalability/configs-and-limits/thresholds.md
646634
-->
647-
635+
No.
648636
###### Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?
649637

650638
<!--
@@ -656,7 +644,7 @@ If any of the resources can be exhausted, how this is mitigated with the existin
656644
Are there any tests that were run/should be run to understand performance characteristics better
657645
and validate the declared limits?
658646
-->
659-
647+
No.
660648
### Troubleshooting
661649

662650
<!--
@@ -671,7 +659,7 @@ details). For now, we leave it here.
671659
-->
672660

673661
###### How does this feature react if the API server and/or etcd is unavailable?
674-
662+
The namespace controller will act exactly the same with/without this feature.
675663
###### What are other known failure modes?
676664

677665
<!--
@@ -686,9 +674,9 @@ For each of them, fill in the following information by copying the below templat
686674
Not required until feature graduated to beta.
687675
- Testing: Are there any tests for failure mode? If not, describe why.
688676
-->
689-
677+
Namespace deletion might hang if pod resources deletion running into issues with the feature gate enabled.
690678
###### What steps should be taken if SLOs are not being met to determine the problem?
691-
679+
Delete the blocking resources manually.
692680
## Implementation History
693681

694682
<!--

keps/sig-api-machinery/5080-ordered-namespace-deletion/kep.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,17 @@ see-also: []
2020
replaces: []
2121

2222
# The target maturity stage in the current dev cycle for this KEP.
23-
stage: beta
23+
stage: stable
2424

2525
# The most recent milestone for which work toward delivery of this KEP has been
2626
# done. This can be the current (upcoming) milestone, if it is being actively
2727
# worked on.
28-
latest-milestone: "v1.33"
28+
latest-milestone: "v1.34"
2929

3030
# The milestone at which this feature was, or is targeted to be, at each stage.
3131
milestone:
3232
beta: "1.30"
33-
stable: ""
33+
stable: "1.34"
3434

3535
# The following PRR answers are required at alpha release
3636
# List the feature gate name and the components for which it must be enabled

0 commit comments

Comments
 (0)