Skip to content

Commit fc2184b

Browse files
committed
KEP-4817: fix metrics to use apiserver_request_total
Signed-off-by: Lionel Jouin <[email protected]>
1 parent fc76a5b commit fc2184b

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

keps/sig-node/4817-resource-claim-device-status/README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -524,7 +524,7 @@ No
524524

525525
Check the `ResourceClaim.Status.Devices`.
526526

527-
The metrics `resourceclaim_status_devices_update_attempts_total` will increase.
527+
The metrics `apiserver_request_total` with labels `group="resource.k8s.io",version="v1beta1",resource="resourceclaims",subresource="status"` will increase.
528528

529529
###### How can someone using this feature know that it is working for their instance?
530530

@@ -544,8 +544,7 @@ N/A
544544

545545
- [x] Metrics
546546
- Metric name:
547-
- "resourceclaim_status_devices_update_attempts_total"
548-
- "resourceclaim_status_devices_update_failures_total"
547+
- `apiserver_request_total{group="resource.k8s.io", version="v1beta1", resource="resourceclaims", subresource="status"}`
549548
- [Optional] Aggregation method:
550549
- Components exposing the metric: kube-apiserver
551550
- [ ] Other (treat as last resort)

keps/sig-node/4817-resource-claim-device-status/kep.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,5 +45,4 @@ feature-gates:
4545
disable-supported: true
4646

4747
metrics:
48-
- resourceclaim_status_devices_update_attempts_total
49-
- resourceclaim_status_devices_update_failures_total
48+
- apiserver_request_total{group="resource.k8s.io", version="v1beta1", resource="resourceclaims", subresource="status"}

0 commit comments

Comments
 (0)