Skip to content

Commit fc258d5

Browse files
committed
swap feedback
1 parent b5198bb commit fc258d5

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

keps/sig-node/2400-node-swap/README.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,8 @@ This section is a recommendation for how to set up your nodes with swap if using
211211
##### Disable swap for system critical daemon
212212

213213
As we were testing this feature, we found degration of services if you allow system critical daemons to swap.
214-
The recommendation is to set the cgroup for the system slice to avoid swap (ie `memory.swap.max 0`).
214+
This could mean that kubelet is performing slower than normal so if you experience this,
215+
we recommend setting the cgroup for the system slice to avoid swap (ie `memory.swap.max 0`).
215216
While doing this, we found that it is still possible for workloads to impact critical daemons.
216217

217218
##### Protect system critical daemons for iolatency
@@ -223,15 +224,16 @@ See [io-control](https://facebookmicrosites.github.io/cgroup2/docs/io-controller
223224

224225
##### Control Plane Swap
225226

226-
We only recommend enabling swap for the worker nodes. The control plane contains mostly Guaranteed QoS Pods, so swap may be disabled mostly.
227+
We only recommend enabling swap for the worker nodes. The control plane contains mostly Guaranteed QoS Pods, so swap may be disabled for the most part.
227228
The main concern would be swapping in the critical services on the control plane which can cause a performance impact.
228229

229230
##### Use of a dedicated disk for swap
230231

231232
We recommend using a separate disk for your swap partition. We recommend the separate disk be [encrypted](#security-risk).
232233
If swap is on a partition or the root filesystem, workloads can interfere with system processes needing to write to disk.
233234
If they occupy the same disk, it's possible processes can overwhelm swap and throw off the I/O of kubelet/container runtime/systemd, which would affect other workloads.
234-
Swap space is located on a disk so it is imperative to make sure your disk is fast enough.
235+
See [#protect-system-critical-daemons-for-iolatency] for more details on that.
236+
Swap space is located on a disk so it is imperative to make sure your disk is fast enough for your use cases.
235237

236238
##### Swap as the default
237239

0 commit comments

Comments
 (0)