Skip to content

Commit fc95a65

Browse files
committed
Update metric names
1 parent 698cd3d commit fc95a65

File tree

1 file changed

+11
-6
lines changed
  • keps/sig-storage/1790-recover-resize-failure

1 file changed

+11
-6
lines changed

keps/sig-storage/1790-recover-resize-failure/README.md

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -449,13 +449,17 @@ if this feature-gate is enabled.
449449

450450
- [X] Metrics
451451
- controller expansion operation duration:
452-
- Metric name: storage_operation_duration_seconds{operation_name=expand_volume}
452+
- Metric name: csi_sidecar_operations_seconds{method_name="/csi.v1.Controller/ControllerExpandVolume}
453453
- [Optional] Aggregation method: percentile
454-
- Components exposing the metric: kube-controller-manager
454+
- Components exposing the metric: external-resizer
455455
- controller expansion operation errors:
456-
- Metric name: storage_operation_errors_total{operation_name=expand_volume}
456+
- Metric name: csi_sidecar_operations_seconds{method_name="/csi.v1.Controller/ControllerExpandVolume, grpc_status_code!="OK"}
457457
- [Optional] Aggregation method: cumulative counter
458-
- Components exposing the metric: kube-controller-manager
458+
- Components exposing the metric: external-resizer
459+
- CSI node expansion operation durations:
460+
- Metric name: csi_operations_seconds{method_name="/csi.v1.Controller/NodeExpandVolume}
461+
- [Optional] Aggregation method: cumulative counter
462+
- Components exposing the metric: kubelet
459463
- node expansion operation duration:
460464
- Metric name: storage_operation_duration_seconds{operation_name=volume_fs_resize}
461465
- [Optional] Aggregation method: percentile
@@ -470,8 +474,9 @@ if this feature-gate is enabled.
470474
###### What are the reasonable SLOs (Service Level Objectives) for the above SLIs?
471475

472476
After this feature is rolled out, there should not be any increase in 95-99 percentile of
473-
both `expand_volume` and `volume_fs_resize` durations. Also the error rate should not increase for
474-
`storage_operation_errors_total` metric.
477+
both `csi_sidecar_operations_seconds{method_name="/csi.v1.Controller/ControllerExpandVolume"}` and `storage_operation_duration_seconds{operation_name=volume_fs_resize}` durations.
478+
479+
Also the error rate should not increase for `csi_sidecar_operations_seconds{method_name="/csi.v1.Controller/ControllerExpandVolume"}` metric.
475480

476481
###### Are there any missing metrics that would be useful to have to improve observability of this feature?
477482

0 commit comments

Comments
 (0)