From 13dfc925658ed1f209b1a818b235aabbad6c016a Mon Sep 17 00:00:00 2001 From: Damien Grisonnet Date: Wed, 1 Feb 2023 14:38:23 +0100 Subject: [PATCH] keps: promote 1748-pod-resource-metrics to stable Signed-off-by: Damien Grisonnet --- keps/prod-readiness/sig-instrumentation/1748.yaml | 2 ++ .../1748-pod-resource-metrics/README.md | 14 ++++++++++++++ .../1748-pod-resource-metrics/kep.yaml | 6 +++--- 3 files changed, 19 insertions(+), 3 deletions(-) diff --git a/keps/prod-readiness/sig-instrumentation/1748.yaml b/keps/prod-readiness/sig-instrumentation/1748.yaml index ff8744e708b..04e9db44640 100644 --- a/keps/prod-readiness/sig-instrumentation/1748.yaml +++ b/keps/prod-readiness/sig-instrumentation/1748.yaml @@ -1,3 +1,5 @@ kep-number: 1748 beta: approver: "@johnbelamaric" +stable: + approver: "@johnbelamaric" diff --git a/keps/sig-instrumentation/1748-pod-resource-metrics/README.md b/keps/sig-instrumentation/1748-pod-resource-metrics/README.md index 6ff46b00449..365b4dc8243 100644 --- a/keps/sig-instrumentation/1748-pod-resource-metrics/README.md +++ b/keps/sig-instrumentation/1748-pod-resource-metrics/README.md @@ -513,6 +513,16 @@ collector. Administrators and visualization tools are the primary target of these metrics and so polling and canvassing of Kube distributions is one source of feedback. +* **How can someone using this feature know that it is working for their instance?** + +- [ ] Events + - Event Reason: +- [ ] API .status + - Condition name: + - Other field: +- [x] Other (treat as last resort) + - Details: By scraping the /metrics/resources endpoint of the scheduler and getting metrics about pods resource requests and limits. + * **What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?** - [ ] Metrics @@ -581,6 +591,10 @@ resource usage (CPU, RAM, disk, IO, ...) in any components?** Negligible CPU use is expected and some increase in network transmit when the scheduler is scraped. +* **Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?** + +No. + ### Troubleshooting The Troubleshooting section currently serves the `Playbook` role. We may consider diff --git a/keps/sig-instrumentation/1748-pod-resource-metrics/kep.yaml b/keps/sig-instrumentation/1748-pod-resource-metrics/kep.yaml index 96d4cdd54eb..013dfc35a22 100644 --- a/keps/sig-instrumentation/1748-pod-resource-metrics/kep.yaml +++ b/keps/sig-instrumentation/1748-pod-resource-metrics/kep.yaml @@ -18,9 +18,9 @@ approvers: - "@ahg-g" see-also: replaces: -latest-milestone: "v1.21" +latest-milestone: "v1.27" milestone: alpha: "v1.20" beta: "v1.21" - stable: "v1.22" -stage: "beta" + stable: "v1.27" +stage: "stable"