Skip to content

changed 1.35 to alpha for DRA extended resource feature #5702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

changed 1.35 to alpha for DRA extended resource feature #5702

wants to merge 1 commit into from
+2 −2

Conversation

@yliaog
Copy link
Contributor

@yliaog yliaog commented Nov 20, 2025 •
edited
Loading

  • One-line PR description:
    changed 1.35 to alpha for DRA extended resource feature
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 20, 2025
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Nov 20, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 20, 2025
@yliaog
Copy link
Contributor Author

yliaog commented Nov 20, 2025

/assign @johnbelamaric

johnbelamaric
johnbelamaric reviewed Nov 20, 2025
View reviewed changes
keps/sig-scheduling/5004-dra-extended-resource/kep.yaml Outdated
@@ -31,8 +31,9 @@ latest-milestone: "v1.35"
# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.34"
beta: "v1.35"
stable: "v1.36"
alpha: "v1.35"
Copy link
Member

@johnbelamaric johnbelamaric Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can leave 1.34 here - that's when it first entered alpha.

Copy link
Contributor Author

@yliaog yliaog Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.34 is still there, at line 33

Copy link
Member

@johnbelamaric johnbelamaric Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, we can't have it twice, it's a map key

Copy link
Contributor Author

@yliaog yliaog Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see. removed the alpha 1.35

@johnbelamaric
Copy link
Member

johnbelamaric commented Nov 20, 2025

/hold for scheduling approvers
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 20, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2025
@johnbelamaric johnbelamaric mentioned this pull request Nov 20, 2025
Open
8 tasks
dipesh-rawat
dipesh-rawat reviewed Nov 21, 2025
View reviewed changes
keps/sig-scheduling/5004-dra-extended-resource/kep.yaml
Copy link
Member

@dipesh-rawat dipesh-rawat Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update line 24 with stage: alpha to ensure the details stay accurate.

enhancements/keps/sig-scheduling/5004-dra-extended-resource/kep.yaml

Lines 23 to 24 in c0c7d33

# The target maturity stage in the current dev cycle for this KEP.
stage: beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnbelamaric johnbelamaric johnbelamaric left review comments

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@dom4ha dom4ha Awaiting requested review from dom4ha

@macsko macsko Awaiting requested review from macsko

Assignees

@johnbelamaric johnbelamaric

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

SIG Scheduling
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yliaog @johnbelamaric @k8s-ci-robot @dipesh-rawat