fix: make some values const

Author: aslafy-z

internal/ingress/annotations/customhttperrors/main_test.go

@@ -27,6 +27,11 @@ import (
 	"k8s.io/ingress-nginx/internal/ingress/resolver"
 )
 
+const (
+	DefaultHttpErrorsString = "400,404,500,502"
+	DefaultHttpErrorsSlice = []int{400, 404, 500, 502}
+)
+
 func buildIngress() *networking.Ingress {
 	return &networking.Ingress{
 		ObjectMeta: meta_v1.ObjectMeta{
@@ -50,7 +55,7 @@ func TestParseCodes(t *testing.T) {
 	ing := buildIngress()
 
 	data := map[string]string{}
-	data[parser.GetAnnotationWithPrefix("custom-http-errors")] = "400,404,500,502"
+	data[parser.GetAnnotationWithPrefix("custom-http-errors")] = DefaultHttpErrorsString
 	ing.SetAnnotations(data)
 
 	i, err := NewParser(&resolver.Mock{}).Parse(ing)
@@ -62,7 +67,7 @@ func TestParseCodes(t *testing.T) {
 		t.Errorf("expected a []int type")
 	}
 
-	expected := []int{400, 404, 500, 502}
+	expected := DefaultHttpErrorsSlice
 	if !reflect.DeepEqual(expected, val) {
 		t.Errorf("expected %v but got %v", expected, val)
 	}
@@ -73,7 +78,7 @@ func TestEnabledSwitch(t *testing.T) {
 
 	data := map[string]string{}
 	data[parser.GetAnnotationWithPrefix("enable-custom-http-errors")] = "true"
-	data[parser.GetAnnotationWithPrefix("custom-http-errors")] = "400,404,500,502"
+	data[parser.GetAnnotationWithPrefix("custom-http-errors")] = DefaultHttpErrorsString
 	ing.SetAnnotations(data)
 
 	i, err := NewParser(&resolver.Mock{}).Parse(ing)
@@ -85,7 +90,7 @@ func TestEnabledSwitch(t *testing.T) {
 		t.Errorf("expected a []int type")
 	}
 
-	expected := []int{400, 404, 500, 502}
+	expected := DefaultHttpErrorsSlice
 	if !reflect.DeepEqual(expected, val) {
 		t.Errorf("expected %v but got %v", expected, val)
 	}
@@ -96,7 +101,7 @@ func TestDisabledSwitch(t *testing.T) {
 
 	data := map[string]string{}
 	data[parser.GetAnnotationWithPrefix("enable-custom-http-errors")] = "false"
-	data[parser.GetAnnotationWithPrefix("custom-http-errors")] = "400,404,500,502"
+	data[parser.GetAnnotationWithPrefix("custom-http-errors")] = DefaultHttpErrorsString
 	ing.SetAnnotations(data)
 
 	i, err := NewParser(&resolver.Mock{}).Parse(ing)
@@ -119,7 +124,7 @@ func TestEnabledByDefault(t *testing.T) {
 
 	data := map[string]string{}
 	data[parser.GetAnnotationWithPrefix("enable-custom-http-errors")] = "fakebool"
-	data[parser.GetAnnotationWithPrefix("custom-http-errors")] = "400,404,500,502"
+	data[parser.GetAnnotationWithPrefix("custom-http-errors")] = DefaultHttpErrorsString
 	ing.SetAnnotations(data)
 
 	i, err := NewParser(&resolver.Mock{}).Parse(ing)
@@ -131,7 +136,7 @@ func TestEnabledByDefault(t *testing.T) {
 		t.Errorf("expected a []int type")
 	}
 
-	expected := []int{400, 404, 500, 502}
+	expected := DefaultHttpErrorsSlice
 	if !reflect.DeepEqual(expected, val) {
 		t.Errorf("expected %v but got %v", expected, val)
 	}