Skip to content

Commit 30c4314

Browse files
authored
Fix print-e2e-suite (#9536)
Before: ``` $ make print-e2e-suite Reached DIND check ELSE block, inside run-in-docker.sh Compiled e2e.test Reached DIND check ELSE block, inside run-in-docker.sh + set -o errexit + set -o nounset + set -o pipefail +++ dirname hack/print-e2e-suite.sh ++ cd hack/.. ++ pwd -P + DIR=/go/src/k8s.io/ingress-nginx + /go/src/k8s.io/ingress-nginx/test/e2e/e2e.test -ginkgo.noColor -ginkgo.dryRun + sed 's|/go/src/k8s.io/ingress-nginx/|File: |g' + sed s/•//g + + head -n-3tail -n+5 You're using deprecated Ginkgo functionality: ============================================= --ginkgo.dryRun is deprecated, use --ginkgo.dry-run instead Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#changed-command-line-flags --ginkgo.noColor is deprecated, use --ginkgo.no-color instead Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#changed-command-line-flags To silence deprecations that can be silenced set the following environment variable: ACK_GINKGO_DEPRECATIONS=2.6.1 Will run 423 of 423 specs ``` After: ``` $ make print-e2e-suite Reached DIND check ELSE block, inside run-in-docker.sh Compiled e2e.test Reached DIND check ELSE block, inside run-in-docker.sh Will run 423 of 423 specs ------------------------------ [Annotations] service-upstream when using the default value (false) and enabling in the annotations should use the Service Cluster IP and Port File: test/e2e/annotations/serviceupstream.go:41 [0.000 seconds] ------------------------------ [...] ``` Signed-off-by: Hervé Werner <[email protected]>
1 parent 0a87031 commit 30c4314

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

hack/print-e2e-suite.sh

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17-
if [ -n "$DEBUG" ]; then
18-
set -x
17+
if [ "$DEBUG" == "true" ]; then
18+
set -x
1919
fi
2020

2121
set -o errexit
@@ -25,5 +25,6 @@ set -o pipefail
2525
DIR=$(cd $(dirname "${BASH_SOURCE}")/.. && pwd -P)
2626

2727
$DIR/test/e2e/e2e.test \
28-
-ginkgo.noColor \
29-
-ginkgo.dryRun | sed "s|$DIR/|File: |g" | sed 's/•//g' | tail -n+5 | head -n-3
28+
--ginkgo.no-color \
29+
--ginkgo.v \
30+
--ginkgo.dry-run | sed "s|$DIR/|File: |g" | sed 's/•//g' | tail -n+5 | head -n-3

0 commit comments

Comments
 (0)