Controller: Fix nil pointer in path validation. (#13681)

Co-authored-by: Burkov Egor <[email protected]>
Co-authored-by: Marco Ebert <[email protected]>

Author: 3 people

internal/ingress/inspector/inspector.go

@@ -55,7 +55,13 @@ func ValidatePathType(ing *networking.Ingress) error {
 				}
 				if path.PathType == nil || *path.PathType != implSpecific {
 					if isValid := validPathType.MatchString(path.Path); !isValid {
-						err = errors.Join(err, fmt.Errorf("path %s cannot be used with pathType %s", path.Path, string(*path.PathType)))
+						var pathTypeStr string
+						if path.PathType != nil {
+							pathTypeStr = string(*path.PathType)
+						} else {
+							pathTypeStr = "<nil>"
+						}
+						err = errors.Join(err, fmt.Errorf("path %s cannot be used with pathType %s", path.Path, pathTypeStr))
 					}
 				}
 			}

internal/ingress/inspector/inspector_test.go

@@ -101,6 +101,9 @@ var (
 									PathType: &prefix,
 									Path:     "/lala/xp\ntest",
 								},
+								{
+									Path: "notvalidpathname-panics",
+								},
 							},
 						},
 					},
@@ -174,6 +177,7 @@ func TestValidatePathType(t *testing.T) {
 				aErr("xpto/lala", "Exact"),
 				aErr("/foo/bar/[a-z]{3}", "Prefix"),
 				aErr("/lala/xp\ntest", "Prefix"),
+				aErr("notvalidpathname-panics", "<nil>"),
 			),
 		},
 	}