Plugin: Change rewriteTargetWithoutCaptureGroup lint to include any numbered capture group. (#13932)

k8s-infra-cherrypick-robot · justdan96 · web-flow · commit 979ec080b043 · 2025-09-12T10:16:07.000-07:00
Co-authored-by: Dan &lt;justdan96@gmail.com&gt;
diff --git a/cmd/plugin/lints/ingress.go b/cmd/plugin/lints/ingress.go
@@ -18,6 +18,7 @@ package lints
 
 import (
 	"fmt"
+	"regexp"
 	"strings"
 
 	networking "k8s.io/api/networking/v1"
@@ -126,7 +127,7 @@ func annotationPrefixIsNginxOrg(ing *networking.Ingress) bool {
 
 func rewriteTargetWithoutCaptureGroup(ing *networking.Ingress) bool {
 	for name, val := range ing.Annotations {
-		if strings.HasSuffix(name, "/rewrite-target") && !strings.Contains(val, "$1") {
+		if strings.HasSuffix(name, "/rewrite-target") && !regexp.MustCompile(`\$\d+`).MatchString(val) {
 			return true
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@ package lints`
`18`	`18`
`19`	`19`	`import (`
`20`	`20`	`"fmt"`
	`21`	`+ "regexp"`
`21`	`22`	`"strings"`
`22`	`23`
`23`	`24`	`networking "k8s.io/api/networking/v1"`
`@@ -126,7 +127,7 @@ func annotationPrefixIsNginxOrg(ing *networking.Ingress) bool {`
`126`	`127`
`127`	`128`	`func rewriteTargetWithoutCaptureGroup(ing *networking.Ingress) bool {`
`128`	`129`	`for name, val := range ing.Annotations {`
`129`		`- if strings.HasSuffix(name, "/rewrite-target") && !strings.Contains(val, "$1") {`
	`130`	+ if strings.HasSuffix(name, "/rewrite-target") && !regexp.MustCompile(`\$\d+`).MatchString(val) {
`130`	`131`	`return true`
`131`	`132`	`}`
`132`	`133`	`}`