small fixes

Author: alexintech

.github/workflows/plugin.yaml

@@ -34,11 +34,12 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: Set GORELEASER_CURRENT_TAG
+      - name: Set a SemVer tag for goreleaser
         if: ${{ startsWith(github.ref, 'refs/tags/controller-') }}
         run: echo "GORELEASER_CURRENT_TAG=${{ github.ref }}" | sed 's/refs\/tags\/controller-//' >> $GITHUB_ENV
 
-      - name: Create local SemVer tag
+      # GoReleaser requires a SemVer tag to be present in the git repository
+      - name: Create a local SemVer tag
         run: git tag "${{ env.GORELEASER_CURRENT_TAG }}"
 
       - name: Run GoReleaser
@@ -52,6 +53,7 @@ jobs:
           GORELEASER_CURRENT_TAG: ${{ env.GORELEASER_CURRENT_TAG }}
 
       - name: Upload artifacts to release
+        if: ${{ startsWith(github.ref, 'refs/tags/controller-') }}
         uses: softprops/action-gh-release@c95fe1489396fe8a9eb87c0abf8aa5b2ef267fda # v2.2.1
         with:
           files: |

.goreleaser.yaml

@@ -1,8 +1,11 @@
 version: 2
 
 project_name: ingress-nginx
+
 release:
+  # Disable uploading release assets to GitHub as it requires SemVer tags
   disable: true
+
 builds:
   - id: ingress-nginx
     goos:
@@ -20,14 +23,16 @@ builds:
     ldflags: |
       -s -w
       -X k8s.io/ingress-nginx/version.COMMIT={{ .Commit }}
-      -X k8s.io/ingress-nginx/version.RELEASE=controller-{{ .Tag }}
+      -X k8s.io/ingress-nginx/version.RELEASE={{ .Tag }}
+
 archives:
   - id: ingress-nginx
     ids:
     - ingress-nginx
     name_template: "kubectl-{{ .ProjectName }}_{{ .Os }}_{{ .Arch }}"
     formats:
     - tar.gz
+
 checksum:
   name_template: "kubectl-{{ .ProjectName }}_checksums.txt"
 
@@ -36,4 +41,4 @@ krews:
     homepage: "https://kubernetes.github.io/ingress-nginx/kubectl-plugin/"
     description: "The official kubectl plugin for ingress-nginx."
     short_description: "Interact with ingress-nginx"
-    url_template: "http://github.com/alexintech/ingress-nginx/releases/download/controller-{{ .Tag }}/{{ .ArtifactName }}"
+    url_template: "http://github.com/kubernetes/ingress-nginx/releases/download/controller-{{ .Tag }}/{{ .ArtifactName }}"