Skip to content

Commit bfd44ab

Browse files
authored
Add v1.25 test and reduce amount of e2e tests (#9018)
1 parent 92534fa commit bfd44ab

File tree

5 files changed

+42
-11
lines changed

5 files changed

+42
-11
lines changed

.github/workflows/ci.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -174,8 +174,8 @@ jobs:
174174
id: kind
175175
uses: engineerd/setup-kind@aa272fe2a7309878ffc2a81c56cfe3ef108ae7d0 #v0.5.0
176176
with:
177-
version: v0.14.0
178-
image: kindest/node:v1.21.12
177+
version: v0.15.0
178+
image: kindest/node:v1.25.0
179179

180180
- uses: geekyeggo/delete-artifact@b73cb986740e466292a536d0e32e2666c56fdeb3 # v1
181181
with:
@@ -208,7 +208,7 @@ jobs:
208208
209209
strategy:
210210
matrix:
211-
k8s: [v1.21.2, v1.22.9, v1.23.6, v1.24.0]
211+
k8s: [v1.23.10, v1.24.4, v1.25.0]
212212

213213
steps:
214214

@@ -224,7 +224,7 @@ jobs:
224224
id: kind
225225
uses: engineerd/setup-kind@aa272fe2a7309878ffc2a81c56cfe3ef108ae7d0 #v0.5.0
226226
with:
227-
version: v0.14.0
227+
version: v0.15.0
228228
config: test/e2e/kind.yaml
229229
image: kindest/node:${{ matrix.k8s }}
230230

@@ -265,7 +265,7 @@ jobs:
265265
266266
strategy:
267267
matrix:
268-
k8s: [v1.21.10, v1.22.9, v1.23.6, v1.24.0]
268+
k8s: [v1.24.4, v1.25.0]
269269

270270
steps:
271271

@@ -281,7 +281,7 @@ jobs:
281281
id: kind
282282
uses: engineerd/setup-kind@aa272fe2a7309878ffc2a81c56cfe3ef108ae7d0 #v0.5.0
283283
with:
284-
version: v0.14.0
284+
version: v0.15.0
285285
config: test/e2e/kind.yaml
286286
image: kindest/node:${{ matrix.k8s }}
287287

@@ -403,8 +403,8 @@ jobs:
403403
if: ${{ steps.filter-images.outputs.kube-webhook-certgen == 'true' }}
404404
uses: engineerd/setup-kind@aa272fe2a7309878ffc2a81c56cfe3ef108ae7d0 #v0.5.0
405405
with:
406-
version: v0.14.0
407-
image: kindest/node:v1.21.12
406+
version: v0.15.0
407+
image: kindest/node:v1.25.0
408408

409409
- name: Set up Go 1.19.0
410410
id: go

build/build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ echo "Building targets for ${ARCH}, generated targets in ${TARGETS_DIR} director
4949

5050
echo "Building ${PKG}/cmd/nginx"
5151

52-
git config --global --add safe.directory /go/src/k8s.io/ingress-nginx
52+
git config --add safe.directory /go/src/k8s.io/ingress-nginx
5353

5454
${GO_BUILD_CMD} \
5555
-trimpath -ldflags="-buildid= -w -s \

rootfs/chroot.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ for dir in "${writeDirs[@]}"; do
4040
chown -R www-data.www-data ${dir};
4141
done
4242

43+
4344
mkdir -p /chroot/lib /chroot/proc /chroot/usr /chroot/bin /chroot/dev /chroot/run
4445
cp /etc/passwd /etc/group /chroot/etc/
4546
cp -a /usr/* /chroot/usr/

test/e2e/settings/pod_security_policy.go

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ package settings
1919
import (
2020
"context"
2121
"net/http"
22+
"strconv"
2223
"strings"
2324

2425
"github.com/onsi/ginkgo/v2"
@@ -41,8 +42,22 @@ var _ = framework.IngressNginxDescribe("[Security] Pod Security Policies", func(
4142
f := framework.NewDefaultFramework("pod-security-policies")
4243

4344
ginkgo.It("should be running with a Pod Security Policy", func() {
45+
k8sversion, err := f.KubeClientSet.Discovery().ServerVersion()
46+
if err != nil {
47+
assert.Nil(ginkgo.GinkgoT(), err, "getting version")
48+
}
49+
50+
numversion, err := strconv.Atoi(k8sversion.Minor)
51+
if err != nil {
52+
assert.Nil(ginkgo.GinkgoT(), err, "converting version")
53+
}
54+
55+
if numversion > 24 {
56+
ginkgo.Skip("PSP not supported in this version")
57+
}
58+
4459
psp := createPodSecurityPolicy()
45-
_, err := f.KubeClientSet.PolicyV1beta1().PodSecurityPolicies().Create(context.TODO(), psp, metav1.CreateOptions{})
60+
_, err = f.KubeClientSet.PolicyV1beta1().PodSecurityPolicies().Create(context.TODO(), psp, metav1.CreateOptions{})
4661
if !k8sErrors.IsAlreadyExists(err) {
4762
assert.Nil(ginkgo.GinkgoT(), err, "creating Pod Security Policy")
4863
}

test/e2e/settings/pod_security_policy_volumes.go

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ package settings
1919
import (
2020
"context"
2121
"net/http"
22+
"strconv"
2223
"strings"
2324

2425
"github.com/onsi/ginkgo/v2"
@@ -37,8 +38,22 @@ var _ = framework.IngressNginxDescribe("[Security] Pod Security Policies with vo
3738
f := framework.NewDefaultFramework("pod-security-policies-volumes")
3839

3940
ginkgo.It("should be running with a Pod Security Policy", func() {
41+
42+
k8sversion, err := f.KubeClientSet.Discovery().ServerVersion()
43+
if err != nil {
44+
assert.Nil(ginkgo.GinkgoT(), err, "getting version")
45+
}
46+
47+
numversion, err := strconv.Atoi(k8sversion.Minor)
48+
if err != nil {
49+
assert.Nil(ginkgo.GinkgoT(), err, "converting version")
50+
}
51+
52+
if numversion > 24 {
53+
ginkgo.Skip("PSP not supported in this version")
54+
}
4055
psp := createPodSecurityPolicy()
41-
_, err := f.KubeClientSet.PolicyV1beta1().PodSecurityPolicies().Create(context.TODO(), psp, metav1.CreateOptions{})
56+
_, err = f.KubeClientSet.PolicyV1beta1().PodSecurityPolicies().Create(context.TODO(), psp, metav1.CreateOptions{})
4257
if !k8sErrors.IsAlreadyExists(err) {
4358
assert.Nil(ginkgo.GinkgoT(), err, "creating Pod Security Policy")
4459
}

0 commit comments

Comments
 (0)