Skip to content

Commit caffea0

Browse files
committed
HTTP/3 disable UDP ports by default
1 parent 14c88b4 commit caffea0

File tree

6 files changed

+3
-36
lines changed

6 files changed

+3
-36
lines changed

build/dev-env.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,6 @@ controller:
8989
digest:
9090
config:
9191
worker-processes: "1"
92-
extraArgs:
93-
enable-quic: "true"
9492
podLabels:
9593
deploy-date: "$(date +%s)"
9694
updateStrategy:

charts/ingress-nginx/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,7 @@ metadata:
317317
| controller.configMapNamespace | string | `""` | Allows customization of the configmap / nginx-configmap namespace; defaults to $(POD_NAMESPACE) |
318318
| controller.containerName | string | `"controller"` | Configures the controller container name |
319319
| controller.containerPort | object | `{"http":80,"https":443}` | Configures the TCP ports that the nginx-controller listens on |
320-
| controller.containerUdpPort | object | `{"quic":443}` | Configures the UDP ports that the nginx-controller listens on |
320+
| controller.containerUdpPort | object | `{}` | Configures the UDP ports that the nginx-controller listens on |
321321
| controller.containerSecurityContext | object | `{}` | Security context for controller containers |
322322
| controller.customTemplate.configMapKey | string | `""` | |
323323
| controller.customTemplate.configMapName | string | `""` | |

charts/ingress-nginx/tests/controller-daemonset_test.yaml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -208,18 +208,6 @@ tests:
208208
- equal:
209209
path: spec.template.spec.runtimeClassName
210210
value: myClass
211-
212-
- it: should create a DaemonSet with a default UDP container port
213-
set:
214-
controller.kind: DaemonSet
215-
asserts:
216-
- contains:
217-
path: spec.template.spec.containers[0].ports
218-
content:
219-
name: quic
220-
containerPort: 443
221-
protocol: UDP
222-
223211
- it: should create a DaemonSet with a custom UDP container port if `controller.containerUdpPort.quic` is set
224212
set:
225213
controller.kind: DaemonSet

charts/ingress-nginx/tests/controller-deployment_test.yaml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -232,15 +232,6 @@ tests:
232232
path: spec.template.spec.runtimeClassName
233233
value: myClass
234234

235-
- it: should create a Deployment with a default UDP container port
236-
asserts:
237-
- contains:
238-
path: spec.template.spec.containers[0].ports
239-
content:
240-
name: quic
241-
containerPort: 443
242-
protocol: UDP
243-
244235
- it: should create a Deployment with a custom UDP container port if `controller.containerUdpPort.quic` is set
245236
set:
246237
controller.containerUdpPort.quic: 1234

charts/ingress-nginx/tests/controller-networkpolicy_test.yaml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,6 @@ tests:
2222
path: metadata.name
2323
value: RELEASE-NAME-ingress-nginx-controller
2424

25-
- it: should create a NetworkPolicy with a default UDP port
26-
set:
27-
controller.networkPolicy.enabled: true
28-
asserts:
29-
- contains:
30-
path: spec.ingress[0].ports
31-
content:
32-
protocol: UDP
33-
port: 443
34-
3525
- it: should create a NetworkPolicy with a custom UDP port if `controller.containerUdpPort.quic` is set
3626
set:
3727
controller.networkPolicy.enabled: true

charts/ingress-nginx/values.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ controller:
5252
http: 80
5353
https: 443
5454
# -- Configures the UDP ports that the nginx-controller listens on
55-
containerUdpPort:
56-
quic: 443
55+
containerUdpPort: []
56+
# quic: 443
5757
# -- Global configuration passed to the ConfigMap consumed by the controller. Values may contain Helm templates.
5858
# Ref.: https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/configmap/
5959
config: {}

0 commit comments

Comments
 (0)