Skip to content

Commit f794185

Browse files
committed
HTTP/3 generate Helm Readme, fix golint issues
1 parent 42d8081 commit f794185

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

charts/ingress-nginx/README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,8 +317,8 @@ metadata:
317317
| controller.configMapNamespace | string | `""` | Allows customization of the configmap / nginx-configmap namespace; defaults to $(POD_NAMESPACE) |
318318
| controller.containerName | string | `"controller"` | Configures the controller container name |
319319
| controller.containerPort | object | `{"http":80,"https":443}` | Configures the TCP ports that the nginx-controller listens on |
320-
| controller.containerUdpPort | object | `{}` | Configures the UDP ports that the nginx-controller listens on |
321320
| controller.containerSecurityContext | object | `{}` | Security context for controller containers |
321+
| controller.containerUdpPort | list | `[]` | Configures the UDP ports that the nginx-controller listens on |
322322
| controller.customTemplate.configMapKey | string | `""` | |
323323
| controller.customTemplate.configMapName | string | `""` | |
324324
| controller.disableLeaderElection | bool | `false` | This configuration disable Nginx Controller Leader Election |
@@ -495,9 +495,11 @@ metadata:
495495
| controller.service.nodePorts.udp | object | `{}` | Node port mapping for external UDP listeners. If left empty, the service controller allocates them from the configured node port range. Example: udp: 53: 30053 |
496496
| controller.service.ports.http | int | `80` | Port the external HTTP listener is published with. |
497497
| controller.service.ports.https | int | `443` | Port the external HTTPS listener is published with. |
498+
| controller.service.ports.quic | int | `443` | Port the external QUIC listener is published with. |
498499
| controller.service.sessionAffinity | string | `""` | Session affinity of the external controller service. Must be either "None" or "ClientIP" if set. Defaults to "None". Ref: https://kubernetes.io/docs/reference/networking/virtual-ips/#session-affinity |
499500
| controller.service.targetPorts.http | string | `"http"` | Port of the ingress controller the external HTTP listener is mapped to. |
500501
| controller.service.targetPorts.https | string | `"https"` | Port of the ingress controller the external HTTPS listener is mapped to. |
502+
| controller.service.targetPorts.quic | string | `"quic"` | Port of the ingress controller the external QUIC listener is mapped to. |
501503
| controller.service.trafficDistribution | string | `""` | Traffic distribution policy of the external controller service. Set to "PreferClose" to route traffic to endpoints that are topologically closer to the client. Ref: https://kubernetes.io/docs/concepts/services-networking/service/#traffic-distribution |
502504
| controller.service.type | string | `"LoadBalancer"` | Type of the external controller service. Ref: https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types |
503505
| controller.shareProcessNamespace | bool | `false` | |

internal/net/net_test.go

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,11 @@ func TestIsPortAvailable(t *testing.T) {
5353
}
5454
defer ln.Close()
5555

56-
p := ln.Addr().(*net.TCPAddr).Port
56+
addr, ok := ln.Addr().(*net.TCPAddr)
57+
if !ok {
58+
t.Fatalf("unexpected type: %T", ln.Addr())
59+
}
60+
p := addr.Port
5761
if IsPortAvailable(p) {
5862
t.Fatalf("expected port %v to not be available", p)
5963
}
@@ -64,13 +68,17 @@ func TestIsUDPPortAvailable(t *testing.T) {
6468
t.Fatal("expected port 0 to be available (random port) but returned false")
6569
}
6670

67-
ln, err := net.ListenPacket("udp", ":0") //nolint:gosec // Ignore the gosec error in testing
71+
ln, err := net.ListenPacket("udp", ":0")
6872
if err != nil {
6973
t.Fatalf("unexpected error: %v", err)
7074
}
7175
defer ln.Close()
7276

73-
p := ln.LocalAddr().(*net.UDPAddr).Port
77+
addr, ok := ln.LocalAddr().(*net.UDPAddr)
78+
if !ok {
79+
t.Fatalf("unexpected type: %T", ln.LocalAddr())
80+
}
81+
p := addr.Port
7482
if IsUDPPortAvailable(p) {
7583
t.Fatalf("expected port %v to not be available", p)
7684
}

0 commit comments

Comments
 (0)