Skip to content

Commit 5ad4f3a

Browse files
authored
Merge pull request #7416 from dargudear-google/provider-gcp-test
ensure prow-build can operate secret manager secrets
2 parents d7c2082 + b70d408 commit 5ad4f3a

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

infra/gcp/bash/prow/ensure-e2e-projects.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ function ensure_e2e_project() {
7373
file.googleapis.com \
7474
logging.googleapis.com \
7575
monitoring.googleapis.com \
76+
secretmanager.googleapis.com \
7677
storage-component.googleapis.com
7778

7879
# TODO: this is what prow.k8s.io uses today, but seems overprivileged, we
@@ -112,6 +113,11 @@ function ensure_e2e_project() {
112113
ensure_project_role_binding "${prj}" \
113114
"serviceAccount:${PROW_BUILD_SVCACCT}" \
114115
"roles/iam.serviceAccountUser"
116+
117+
# Ensure GCP Default Compute Service Account can administer Secret Manager secrets
118+
ensure_project_role_binding "${prj}" \
119+
"serviceAccount:${PROW_BUILD_SVCACCT}" \
120+
"roles/secretmanager.admin"
115121

116122
# TODO: this is what prow.k8s.io uses today, but seems overprivileged, we
117123
# could consider using a more limited custom IAM role instead

0 commit comments

Comments
 (0)