Skip to content

ktesting: -vmodule not working #420

@pohly

Description

@pohly

/kind bug

What steps did you take and what happened:

Debugging some of my code with -v=1 -vmodule=resourceslicecontroller=5 set by k8s.io/kubernetes/test/utils/ktesting.

What did you expect to happen:

Get log output from resourceslicecontroller.go.

Anything else you would like to add:

Fix:

$ git diff vendor
diff --git a/vendor/k8s.io/klog/v2/ktesting/testinglogger.go b/vendor/k8s.io/klog/v2/ktesting/testinglogger.go
index b6c7bb2e82d..74184dc9a99 100644
--- a/vendor/k8s.io/klog/v2/ktesting/testinglogger.go
+++ b/vendor/k8s.io/klog/v2/ktesting/testinglogger.go
@@ -307,7 +307,7 @@ func (l tlogger) Info(level int, msg string, kvList ...interface{}) {
 }
 
 func (l tlogger) Enabled(level int) bool {
-       return l.shared.config.vstate.Enabled(verbosity.Level(level), 1)
+       return l.shared.config.vstate.Enabled(verbosity.Level(level), l.shared.callDepth+1)
 }
 
 func (l tlogger) Error(err error, msg string, kvList ...interface{}) {

Metadata

Metadata

Assignees

Labels

kind/bugCategorizes issue or PR as related to a bug.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

Type

No type

Projects

Status

Needs Triage

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions