Skip to content

Commit 1851bfa

Browse files
committed
fix unitests
1 parent c9bb453 commit 1851bfa

File tree

2 files changed

+17
-10
lines changed

2 files changed

+17
-10
lines changed

internal/store/pod_test.go

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -573,7 +573,8 @@ func TestPodStore(t *testing.T) {
573573
StartedAt: metav1.Time{
574574
Time: time.Unix(1501777018, 0),
575575
},
576-
Reason: "OOMKilled",
576+
Reason: "OOMKilled",
577+
ExitCode: 137,
577578
},
578579
},
579580
},
@@ -709,7 +710,8 @@ func TestPodStore(t *testing.T) {
709710
},
710711
LastTerminationState: v1.ContainerState{
711712
Terminated: &v1.ContainerStateTerminated{
712-
Reason: "OOMKilled",
713+
Reason: "OOMKilled",
714+
ExitCode: 137,
713715
},
714716
},
715717
},
@@ -735,7 +737,7 @@ func TestPodStore(t *testing.T) {
735737
kube_pod_container_state_started{container="container7",namespace="ns6",pod="pod6",uid="uid6"} 1.501777018e+09
736738
kube_pod_container_status_terminated{container="container7",namespace="ns6",pod="pod6",uid="uid6"} 0
737739
kube_pod_container_status_waiting{container="container7",namespace="ns6",pod="pod6",uid="uid6"} 0
738-
kube_pod_container_status_last_terminated_reason{container="container7",namespace="ns6",pod="pod6",reason="OOMKilled",uid="uid6"} 1
740+
kube_pod_container_status_last_terminated_reason{container="container7",namespace="ns6",pod="pod6",reason="OOMKilled",uid="uid6",exitcode="137"} 1
739741
`,
740742
MetricNames: []string{
741743
"kube_pod_container_status_last_terminated_reason",
@@ -774,7 +776,8 @@ func TestPodStore(t *testing.T) {
774776
},
775777
LastTerminationState: v1.ContainerState{
776778
Terminated: &v1.ContainerStateTerminated{
777-
Reason: "DeadlineExceeded",
779+
Reason: "DeadlineExceeded",
780+
ExitCode: 143,
778781
},
779782
},
780783
},
@@ -797,7 +800,7 @@ func TestPodStore(t *testing.T) {
797800
# TYPE kube_pod_container_status_waiting gauge
798801
# TYPE kube_pod_container_status_waiting_reason gauge
799802
kube_pod_container_state_started{container="container7",namespace="ns7",pod="pod7",uid="uid7"} 1.501777018e+09
800-
kube_pod_container_status_last_terminated_reason{container="container7",namespace="ns7",pod="pod7",reason="DeadlineExceeded",uid="uid7"} 1
803+
kube_pod_container_status_last_terminated_reason{container="container7",namespace="ns7",pod="pod7",reason="DeadlineExceeded",uid="uid7",exitcode="143"} 1
801804
kube_pod_container_status_running{container="container7",namespace="ns7",pod="pod7",uid="uid7"} 1
802805
kube_pod_container_status_terminated{container="container7",namespace="ns7",pod="pod7",uid="uid7"} 0
803806
kube_pod_container_status_waiting{container="container7",namespace="ns7",pod="pod7",uid="uid7"} 0
@@ -2019,7 +2022,8 @@ func BenchmarkPodStore(b *testing.B) {
20192022
},
20202023
LastTerminationState: v1.ContainerState{
20212024
Terminated: &v1.ContainerStateTerminated{
2022-
Reason: "OOMKilled",
2025+
Reason: "OOMKilled",
2026+
ExitCode: 137,
20232027
},
20242028
},
20252029
},
@@ -2035,7 +2039,8 @@ func BenchmarkPodStore(b *testing.B) {
20352039
},
20362040
LastTerminationState: v1.ContainerState{
20372041
Terminated: &v1.ContainerStateTerminated{
2038-
Reason: "OOMKilled",
2042+
Reason: "OOMKilled",
2043+
ExitCode: 137,
20392044
},
20402045
},
20412046
},
@@ -2051,7 +2056,8 @@ func BenchmarkPodStore(b *testing.B) {
20512056
},
20522057
LastTerminationState: v1.ContainerState{
20532058
Terminated: &v1.ContainerStateTerminated{
2054-
Reason: "OOMKilled",
2059+
Reason: "OOMKilled",
2060+
ExitCode: 137,
20552061
},
20562062
},
20572063
},

pkg/app/server_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ kube_pod_container_resource_requests{namespace="default",pod="pod0",uid="abc-0",
297297
kube_pod_container_resource_requests{namespace="default",pod="pod0",uid="abc-0",container="pod1_con1",node="node1",resource="storage",unit="byte"} 4e+08
298298
kube_pod_container_resource_requests{namespace="default",pod="pod0",uid="abc-0",container="pod1_con2",node="node1",resource="cpu",unit="core"} 0.3
299299
kube_pod_container_resource_requests{namespace="default",pod="pod0",uid="abc-0",container="pod1_con2",node="node1",resource="memory",unit="byte"} 2e+08
300-
kube_pod_container_status_last_terminated_reason{namespace="default",pod="pod0",uid="abc-0",container="pod1_con1",reason="OOMKilled"} 1
300+
kube_pod_container_status_last_terminated_reason{namespace="default",pod="pod0",uid="abc-0",container="pod1_con1",reason="OOMKilled",exitcode="137"} 1
301301
kube_pod_container_status_ready{namespace="default",pod="pod0",uid="abc-0",container="pod1_con1"} 0
302302
kube_pod_container_status_ready{namespace="default",pod="pod0",uid="abc-0",container="pod1_con2"} 0
303303
kube_pod_container_status_restarts_total{namespace="default",pod="pod0",uid="abc-0",container="pod1_con1"} 0
@@ -794,7 +794,8 @@ func pod(client *fake.Clientset, index int) error {
794794
},
795795
LastTerminationState: v1.ContainerState{
796796
Terminated: &v1.ContainerStateTerminated{
797-
Reason: "OOMKilled",
797+
Reason: "OOMKilled",
798+
ExitCode: 137,
798799
},
799800
},
800801
},

0 commit comments

Comments
 (0)