filter unset field and add unit test

Author: whitebear009

internal/store/horizontalpodautoscaler.go

@@ -135,51 +135,54 @@ func hpaMetricFamilies(allowAnnotationsList, allowLabelsList []string) []generat
 					var metricName string
 
 					var v [metricTargetTypeCount]float64
+					var ok [metricTargetTypeCount]bool
 
 					switch m.Type {
 					case autoscaling.ObjectMetricSourceType:
 						metricName = m.Object.Metric.Name
 
 						if m.Object.Target.Value != nil {
-							v[value] = float64(m.Object.Target.Value.MilliValue()) / 1000
+							v[value], ok[value] = float64(m.Object.Target.Value.MilliValue())/1000, true
 						}
 						if m.Object.Target.AverageValue != nil {
-							v[average] = float64(m.Object.Target.AverageValue.MilliValue()) / 1000
+							v[average], ok[average] = float64(m.Object.Target.AverageValue.MilliValue())/1000, true
 						}
 					case autoscaling.PodsMetricSourceType:
 						metricName = m.Pods.Metric.Name
 
-						v[average] = float64(m.Pods.Target.AverageValue.MilliValue()) / 1000
+						v[average], ok[average] = float64(m.Pods.Target.AverageValue.MilliValue())/1000, true
 					case autoscaling.ResourceMetricSourceType:
 						metricName = string(m.Resource.Name)
 
 						if m.Resource.Target.AverageUtilization != nil {
-							v[utilization] = float64(*m.Resource.Target.AverageUtilization)
+							v[utilization], ok[utilization] = float64(*m.Resource.Target.AverageUtilization), true
 						}
 
 						if m.Resource.Target.AverageValue != nil {
-							v[average] = float64(m.Resource.Target.AverageValue.MilliValue()) / 1000
+							v[average], ok[average] = float64(m.Resource.Target.AverageValue.MilliValue())/1000, true
 						}
 					case autoscaling.ExternalMetricSourceType:
 						metricName = m.External.Metric.Name
 
 						if m.External.Target.Value != nil {
-							v[value] = float64(m.External.Target.Value.MilliValue()) / 1000
+							v[value], ok[value] = float64(m.External.Target.Value.MilliValue())/1000, true
 						}
 						if m.External.Target.AverageValue != nil {
-							v[average] = float64(m.External.Target.AverageValue.MilliValue()) / 1000
+							v[average], ok[average] = float64(m.External.Target.AverageValue.MilliValue())/1000, true
 						}
 					default:
 						// Skip unsupported metric type
 						continue
 					}
 
 					for i := range v {
-						ms = append(ms, &metric.Metric{
-							LabelKeys:   targetMetricLabels,
-							LabelValues: []string{metricName, metricTargetType(i).String()},
-							Value:       v[i],
-						})
+						if ok[i] {
+							ms = append(ms, &metric.Metric{
+								LabelKeys:   targetMetricLabels,
+								LabelValues: []string{metricName, metricTargetType(i).String()},
+								Value:       v[i],
+							})
+						}
 					}
 				}
 				return &metric.Family{Metrics: ms}

internal/store/horizontalpodautoscaler_test.go

@@ -80,7 +80,7 @@ func TestHPAStore(t *testing.T) {
 								},
 								Target: autoscaling.MetricTarget{
 									Value:        resourcePtr(resource.MustParse("10")),
-									AverageValue: resourcePtr(resource.MustParse("12")),
+									AverageValue: resourcePtr(resource.MustParse("0.5")),
 								},
 							},
 						},
@@ -193,7 +193,7 @@ func TestHPAStore(t *testing.T) {
 				kube_horizontalpodautoscaler_spec_min_replicas{horizontalpodautoscaler="hpa1",namespace="ns1"} 2
 				kube_horizontalpodautoscaler_spec_target_metric{horizontalpodautoscaler="hpa1",metric_name="cpu",metric_target_type="utilization",namespace="ns1"} 80
 				kube_horizontalpodautoscaler_spec_target_metric{horizontalpodautoscaler="hpa1",metric_name="events",metric_target_type="average",namespace="ns1"} 30
-				kube_horizontalpodautoscaler_spec_target_metric{horizontalpodautoscaler="hpa1",metric_name="hits",metric_target_type="average",namespace="ns1"} 12
+				kube_horizontalpodautoscaler_spec_target_metric{horizontalpodautoscaler="hpa1",metric_name="hits",metric_target_type="average",namespace="ns1"} 0.5
 				kube_horizontalpodautoscaler_spec_target_metric{horizontalpodautoscaler="hpa1",metric_name="hits",metric_target_type="value",namespace="ns1"} 10
 				kube_horizontalpodautoscaler_spec_target_metric{horizontalpodautoscaler="hpa1",metric_name="memory",metric_target_type="average",namespace="ns1"} 819200
 				kube_horizontalpodautoscaler_spec_target_metric{horizontalpodautoscaler="hpa1",metric_name="memory",metric_target_type="utilization",namespace="ns1"} 80