Merge pull request #2465 from mrueg/newreflectorwithoptions

k8s-ci-robot · web-flow · commit 45b5a26c3ee8 · 2024-08-05T08:09:00.000-07:00
chore: Replace NewReflector with NewReflectorWithOptions func
diff --git a/internal/store/builder.go b/internal/store/builder.go
@@ -603,7 +603,7 @@ func (b *Builder) startReflector(
 	useAPIServerCache bool,
 ) {
 	instrumentedListWatch := watch.NewInstrumentedListerWatcher(listWatcher, b.listWatchMetrics, reflect.TypeOf(expectedType).String(), useAPIServerCache)
-	reflector := cache.NewReflector(sharding.NewShardedListWatch(b.shard, b.totalShards, instrumentedListWatch), expectedType, store, 0)
+	reflector := cache.NewReflectorWithOptions(sharding.NewShardedListWatch(b.shard, b.totalShards, instrumentedListWatch), expectedType, store, cache.ReflectorOptions{ResyncPeriod: 0})
 	go reflector.Run(b.ctx.Done())
 }
 
diff --git a/tests/lib/lib_test.go b/tests/lib/lib_test.go
@@ -79,7 +79,7 @@ func serviceCollector(kubeClient clientset.Interface) *metricsstore.MetricsStore
 		},
 	}
 
-	r := cache.NewReflector(&lw, &v1.Service{}, store, 0)
+	r := cache.NewReflectorWithOptions(&lw, &v1.Service{}, store, cache.ReflectorOptions{ResyncPeriod: 0})
 
 	go r.Run(context.TODO().Done())
 

Original file line number	Diff line number	Diff line change
`@@ -603,7 +603,7 @@ func (b *Builder) startReflector(`
`603`	`603`	`useAPIServerCache bool,`
`604`	`604`	`) {`
`605`	`605`	`instrumentedListWatch := watch.NewInstrumentedListerWatcher(listWatcher, b.listWatchMetrics, reflect.TypeOf(expectedType).String(), useAPIServerCache)`
`606`		`- reflector := cache.NewReflector(sharding.NewShardedListWatch(b.shard, b.totalShards, instrumentedListWatch), expectedType, store, 0)`
	`606`	`+ reflector := cache.NewReflectorWithOptions(sharding.NewShardedListWatch(b.shard, b.totalShards, instrumentedListWatch), expectedType, store, cache.ReflectorOptions{ResyncPeriod: 0})`
`607`	`607`	`go reflector.Run(b.ctx.Done())`
`608`	`608`	`}`
`609`	`609`
Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ func serviceCollector(kubeClient clientset.Interface) *metricsstore.MetricsStore`
`79`	`79`	`},`
`80`	`80`	`}`
`81`	`81`
`82`		`- r := cache.NewReflector(&lw, &v1.Service{}, store, 0)`
	`82`	`+ r := cache.NewReflectorWithOptions(&lw, &v1.Service{}, store, cache.ReflectorOptions{ResyncPeriod: 0})`
`83`	`83`
`84`	`84`	`go r.Run(context.TODO().Done())`
`85`	`85`