fixup! feat: add kube_persistentvolume_volume_mode metric

ricardoapl · ricardoapl · commit 610918ea2407 · 2024-04-15T17:32:12.000+01:00
Signed-off-by: Ricardo Lopes &lt;ricardoapl.dev@gmail.com&gt;
diff --git a/docs/metrics/storage/persistentvolume-metrics.md b/docs/metrics/storage/persistentvolume-metrics.md
@@ -11,7 +11,7 @@
 | kube_persistentvolume_created            | Gauge       | Unix creation timestamp                                                                                                   | seconds                 | `persistentvolume`=&lt;persistentvolume-name&gt; <br>                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                | EXPERIMENTAL |
 | kube_persistentvolume_deletion_timestamp | Gauge       | Unix deletion timestamp                                                                                                   | seconds                 | `persistentvolume`=&lt;persistentvolume-name&gt; <br>                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                | EXPERIMENTAL |
 | kube_persistentvolume_csi_attributes     | Gauge       | CSI attributes of the Persistent Volume, disabled by default, manage with [--metric-opt-in-list](../../developer/cli-arguments.md))     |                         | `persistentvolume`=&lt;persistentvolume-name&gt; <br> `csi_mounter`=&lt;csi-mounter&gt; <br> `csi_map_options`=&lt;csi-map-options&gt;                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                               | EXPERIMENTAL |
-| kube_persistentvolume_volume_mode       | Gauge       |                                                                                                                           |                         | `persistentvolume`=&lt;persistentvolume-name&gt; <br>`volumemode`=&lt;volumemode&gt;                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                   | EXPERIMENTAL       |
+| kube_persistentvolume_volume_mode       | Gauge       | Volume Mode information for the PersistentVolume.                                                                          |                         | `persistentvolume`=&lt;persistentvolume-name&gt; <br>`volumemode`=&lt;volumemode&gt;                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                   | EXPERIMENTAL       |
 
 ## Useful metrics queries
 
diff --git a/internal/store/persistentvolume.go b/internal/store/persistentvolume.go
@@ -394,7 +394,7 @@ func persistentVolumeMetricFamilies(allowAnnotationsList, allowLabelsList []stri
 		),
 		*generator.NewFamilyGeneratorWithStability(
 			"kube_persistentvolume_volume_mode",
-			"Volume Mode information for PersistentVolume.",
+			"Volume Mode information for the PersistentVolume.",
 			metric.Gauge,
 			basemetrics.ALPHA,
 			"",
diff --git a/internal/store/persistentvolume_test.go b/internal/store/persistentvolume_test.go
@@ -754,7 +754,7 @@ func TestPersistentVolumeStore(t *testing.T) {
 				},
 			},
 			Want: `
-					# HELP kube_persistentvolume_volume_mode Volume Mode information for PersistentVolume.
+					# HELP kube_persistentvolume_volume_mode Volume Mode information for the PersistentVolume.
 					# TYPE kube_persistentvolume_volume_mode gauge
 					kube_persistentvolume_volume_mode{persistentvolume="test-default-volumemode",volumemode="Filesystem"} 1
 				`,
@@ -770,7 +770,7 @@ func TestPersistentVolumeStore(t *testing.T) {
 				},
 			},
 			Want: `
-					# HELP kube_persistentvolume_volume_mode Volume Mode information for PersistentVolume.
+					# HELP kube_persistentvolume_volume_mode Volume Mode information for the PersistentVolume.
 					# TYPE kube_persistentvolume_volume_mode gauge
 					kube_persistentvolume_volume_mode{persistentvolume="test-block-volumemode",volumemode="Block"} 1
 				`,
