Skip to content

Commit 7f453f0

Browse files
committed
Fix none to blank string
1 parent 242cea3 commit 7f453f0

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

internal/store/ingress.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ func ingressMetricFamilies(allowAnnotationsList, allowLabelsList []string) []gen
150150
} else {
151151
ms = append(ms, &metric.Metric{
152152
LabelKeys: []string{"host", "path", "service_name", "service_port"},
153-
LabelValues: []string{rule.Host, path.Path, "<none>", "<none>"},
153+
LabelValues: []string{rule.Host, path.Path, "", ""},
154154
Value: 1,
155155
})
156156
}

internal/store/ingress_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ func TestIngressStore(t *testing.T) {
169169
kube_ingress_created{namespace="ns4",ingress="ingress4"} 1.501569018e+09
170170
kube_ingress_labels{namespace="ns4",ingress="ingress4"} 1
171171
kube_ingress_path{namespace="ns4",ingress="ingress4",host="somehost",path="/somepath",service_name="someservice",service_port="1234"} 1
172-
kube_ingress_path{namespace="ns4",ingress="ingress4",host="somehost",path="/somepath2",service_name="<none>",service_port="<none>"} 1
172+
kube_ingress_path{namespace="ns4",ingress="ingress4",host="somehost",path="/somepath2",service_name="",service_port=""} 1
173173
`,
174174
MetricNames: []string{"kube_ingress_info", "kube_ingress_metadata_resource_version", "kube_ingress_created", "kube_ingress_labels", "kube_ingress_path", "kube_ingress_tls"},
175175
},

0 commit comments

Comments
 (0)