Skip to content

Commit b1c2e0c

Browse files
authored
Merge pull request #2467 from CatherineF-dev/patch-12
fix: e2e test failure
2 parents 312b298 + b43702e commit b1c2e0c

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

examples/daemonsetsharding/deployment-no-node-pods-service.yaml renamed to examples/daemonsetsharding/deployment-unscheduled-pods-fetching-service.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ kind: Service
33
metadata:
44
labels:
55
app.kubernetes.io/component: exporter
6-
app.kubernetes.io/name: kube-state-metrics-no-node-pods
6+
app.kubernetes.io/name: kube-state-metrics-unscheduled-pods-fetching
77
app.kubernetes.io/version: 2.13.0
8-
name: kube-state-metrics-no-node-pods
8+
name: kube-state-metrics-unscheduled-pods-fetching
99
namespace: kube-system
1010
spec:
1111
clusterIP: None
@@ -17,4 +17,4 @@ spec:
1717
port: 8081
1818
targetPort: telemetry
1919
selector:
20-
app.kubernetes.io/name: kube-state-metrics-no-node-pods
20+
app.kubernetes.io/name: kube-state-metrics-unscheduled-pods-fetching

jsonnet/kube-state-metrics/kube-state-metrics.libsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@
415415
'--track-unscheduled-pods',
416416
],
417417
};
418-
local shardksmname = ksm.name + '-no-node-pods';
418+
local shardksmname = ksm.name + '-unscheduled-pods-fetching';
419419
std.mergePatch(
420420
ksm.service,
421421
{

tests/e2e.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,11 @@ function kube_pod_up() {
122122
function test_daemonset() {
123123
sed -i "s|${KUBE_STATE_METRICS_CURRENT_IMAGE_NAME}:v.*|${KUBE_STATE_METRICS_IMAGE_NAME}:${KUBE_STATE_METRICS_IMAGE_TAG}|g" ./examples/daemonsetsharding/deployment.yaml
124124
sed -i "s|${KUBE_STATE_METRICS_CURRENT_IMAGE_NAME}:v.*|${KUBE_STATE_METRICS_IMAGE_NAME}:${KUBE_STATE_METRICS_IMAGE_TAG}|g" ./examples/daemonsetsharding/daemonset.yaml
125-
sed -i "s|${KUBE_STATE_METRICS_CURRENT_IMAGE_NAME}:v.*|${KUBE_STATE_METRICS_IMAGE_NAME}:${KUBE_STATE_METRICS_IMAGE_TAG}|g" ./examples/daemonsetsharding/deployment-no-node-pods.yaml
125+
sed -i "s|${KUBE_STATE_METRICS_CURRENT_IMAGE_NAME}:v.*|${KUBE_STATE_METRICS_IMAGE_NAME}:${KUBE_STATE_METRICS_IMAGE_TAG}|g" ./examples/daemonsetsharding/deployment-unscheduled-pods-fetching.yaml
126126

127127
kubectl get deployment -n kube-system
128128
kubectl create -f ./examples/daemonsetsharding
129-
kube_state_metrics_up kube-state-metrics-no-node-pods
129+
kube_state_metrics_up kube-state-metrics-unscheduled-pods-fetching
130130
kube_state_metrics_up kube-state-metrics
131131
kube_state_metrics_up kube-state-metrics-shard
132132
kubectl apply -f ./tests/e2e/testdata/pods.yaml
@@ -147,11 +147,11 @@ function test_daemonset() {
147147
exit 1
148148
fi
149149

150-
kubectl logs deployment/kube-state-metrics-no-node-pods -n kube-system
150+
kubectl logs deployment/kube-state-metrics-unscheduled-pods-fetching -n kube-system
151151
sleep 2
152152
kubectl get pods -A --field-selector spec.nodeName=""
153153
sleep 2
154-
pendingpod2="$(curl -s "http://localhost:8001/api/v1/namespaces/kube-system/services/kube-state-metrics-no-node-pods:http-metrics/proxy/metrics" | grep "pendingpod2" | grep -c "kube_pod_info" )"
154+
pendingpod2="$(curl -s "http://localhost:8001/api/v1/namespaces/kube-system/services/kube-state-metrics-unscheduled-pods-fetching:http-metrics/proxy/metrics" | grep "pendingpod2" | grep -c "kube_pod_info" )"
155155
if [ "${pendingpod2}" != "${expected_num_pod}" ]; then
156156
echo "metric kube_pod_info for pendingpod2 doesn't show up only once, got ${runningpod1} times"
157157
exit 1

0 commit comments

Comments
 (0)