Skip to content

Commit b5e8e6f

Browse files
committed
move to subcommand
1 parent 0d37b8f commit b5e8e6f

File tree

17 files changed

+166
-443
lines changed

17 files changed

+166
-443
lines changed

Makefile

Lines changed: 9 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ GIT_COMMIT ?= $(shell git rev-parse --short HEAD)
1515
OS ?= $(shell uname -s | tr A-Z a-z)
1616
ALL_ARCH = amd64 arm arm64 ppc64le s390x
1717
PKG = github.com/prometheus/common
18-
PROMETHEUS_VERSION = 2.45.0
19-
GO_VERSION = 1.20.6
18+
PROMETHEUS_VERSION = 2.37.0
19+
GO_VERSION = 1.19.2
2020
IMAGE = $(REGISTRY)/kube-state-metrics
2121
MULTI_ARCH_IMG = $(IMAGE)-$(ARCH)
2222
USER ?= $(shell id -u -n)
@@ -43,11 +43,6 @@ licensecheck:
4343

4444
lint: shellcheck licensecheck
4545
golangci-lint run
46-
cd exp/metric-gen && golangci-lint run
47-
48-
lint-fix:
49-
golangci-lint run --fix -v
50-
cd exp/metric-gen && golangci-lint run --fix -v
5146

5247
doccheck: generate
5348
@echo "- Checking if the generated documentation is up to date..."
@@ -65,18 +60,10 @@ doccheck: generate
6560
build-local:
6661
GOOS=$(OS) GOARCH=$(ARCH) CGO_ENABLED=0 go build -ldflags "-s -w -X ${PKG}/version.Version=${TAG} -X ${PKG}/version.Revision=${GIT_COMMIT} -X ${PKG}/version.Branch=${BRANCH} -X ${PKG}/version.BuildUser=${USER}@${HOST} -X ${PKG}/version.BuildDate=${BUILD_DATE}" -o kube-state-metrics
6762

68-
build-metric-gen-local:
69-
cd exp/metric-gen && GOOS=$(OS) GOARCH=$(ARCH) CGO_ENABLED=0 go build -ldflags "-s -w -X ${PKG}/version.Version=${TAG} -X ${PKG}/version.Revision=${GIT_COMMIT} -X ${PKG}/version.Branch=${BRANCH} -X ${PKG}/version.BuildUser=${USER}@${HOST} -X ${PKG}/version.BuildDate=${BUILD_DATE}" -o ../../metric-gen
70-
71-
build: kube-state-metrics metric-gen
63+
build: kube-state-metrics
7264

7365
kube-state-metrics:
74-
# Need to update git setting to prevent failing builds due to https://github.com/docker-library/golang/issues/452
75-
${DOCKER_CLI} run --rm -v "${PWD}:/go/src/k8s.io/kube-state-metrics" -w /go/src/k8s.io/kube-state-metrics -e GOOS=$(OS) -e GOARCH=$(ARCH) golang:${GO_VERSION} git config --global --add safe.directory "*" && make build-local
76-
77-
metric-gen:
78-
# Need to update git setting to prevent failing builds due to https://github.com/docker-library/golang/issues/452
79-
${DOCKER_CLI} run --rm -v "${PWD}:/go/src/k8s.io/kube-state-metrics" -w /go/src/k8s.io/kube-state-metrics -e GOOS=$(OS) -e GOARCH=$(ARCH) golang:${GO_VERSION} git config --global --add safe.directory "*" && make build-metric-gen-local
66+
${DOCKER_CLI} run --rm -v "${PWD}:/go/src/k8s.io/kube-state-metrics" -w /go/src/k8s.io/kube-state-metrics -e GOOS=$(OS) -e GOARCH=$(ARCH) golang:${GO_VERSION} make build-local
8067

8168
test-unit:
8269
GOOS=$(shell uname -s | tr A-Z a-z) GOARCH=$(ARCH) $(TESTENVVAR) go test --race $(FLAGS) $(PKGS)
@@ -91,7 +78,7 @@ shellcheck:
9178
# the two.
9279
test-benchmark-compare:
9380
@git fetch
94-
./tests/compare_benchmarks.sh main
81+
./tests/compare_benchmarks.sh master
9582
./tests/compare_benchmarks.sh ${LATEST_RELEASE_BRANCH}
9683

9784
all: all-container
@@ -123,7 +110,7 @@ push-multi-arch:
123110
${DOCKER_CLI} manifest push --purge $(IMAGE):$(TAG)
124111

125112
clean:
126-
rm -f kube-state-metrics metric-gen
113+
rm -f kube-state-metrics
127114
git clean -Xfd .
128115

129116
e2e:
@@ -143,7 +130,7 @@ examples/prometheus-alerting-rules/alerts.yaml: jsonnet $(shell find jsonnet | g
143130
mkdir -p examples/prometheus-alerting-rules
144131
jsonnet -J scripts/vendor scripts/mixin.jsonnet | gojsontoyaml > examples/prometheus-alerting-rules/alerts.yaml
145132

146-
examples: examples/standard examples/autosharding examples/daemonsetsharding mixin
133+
examples: examples/standard examples/autosharding mixin
147134

148135
examples/standard: jsonnet $(shell find jsonnet | grep ".libsonnet") scripts/standard.jsonnet scripts/vendor VERSION
149136
mkdir -p examples/standard
@@ -155,21 +142,16 @@ examples/autosharding: jsonnet $(shell find jsonnet | grep ".libsonnet") scripts
155142
jsonnet -J scripts/vendor -m examples/autosharding --ext-str version="$(VERSION)" scripts/autosharding.jsonnet | xargs -I{} sh -c 'cat {} | gojsontoyaml > `echo {} | sed "s/\(.\)\([A-Z]\)/\1-\2/g" | tr "[:upper:]" "[:lower:]"`.yaml' -- {}
156143
find examples -type f ! -name '*.yaml' -delete
157144

158-
examples/daemonsetsharding: jsonnet $(shell find jsonnet | grep ".libsonnet") scripts/daemonsetsharding.jsonnet scripts/vendor VERSION
159-
mkdir -p examples/daemonsetsharding
160-
jsonnet -J scripts/vendor -m examples/daemonsetsharding --ext-str version="$(VERSION)" scripts/daemonsetsharding.jsonnet | xargs -I{} sh -c 'cat {} | gojsontoyaml > `echo {} | sed "s/\(.\)\([A-Z]\)/\1-\2/g" | tr "[:upper:]" "[:lower:]"`.yaml' -- {}
161-
find examples -type f ! -name '*.yaml' -delete
162-
163145
scripts/vendor: scripts/jsonnetfile.json scripts/jsonnetfile.lock.json
164146
cd scripts && jb install
165147

166148
install-tools:
167149
@echo Installing tools from tools.go
168-
grep '^\s*_' tools/tools.go | awk '{print $$2}' | xargs -tI % go install -mod=readonly -modfile=tools/go.mod %
150+
@cat tools/tools.go | grep _ | awk -F'"' '{print $$2}' | xargs -tI % go install %
169151

170152
install-promtool:
171153
@echo Installing promtool
172154
@wget -qO- "https://github.com/prometheus/prometheus/releases/download/v${PROMETHEUS_VERSION}/prometheus-${PROMETHEUS_VERSION}.${OS}-${ARCH}.tar.gz" |\
173155
tar xvz --strip-components=1 prometheus-${PROMETHEUS_VERSION}.${OS}-${ARCH}/promtool
174156

175-
.PHONY: all build build-local all-push all-container container container-* do-push-* sub-push-* push push-multi-arch test-unit test-rules test-benchmark-compare clean e2e validate-modules shellcheck licensecheck lint lint-fix generate embedmd
157+
.PHONY: all build build-local all-push all-container container container-* do-push-* sub-push-* push push-multi-arch test-unit test-rules test-benchmark-compare clean e2e validate-modules shellcheck licensecheck lint generate embedmd

exp/metric-gen/go.mod

Lines changed: 0 additions & 74 deletions
This file was deleted.

0 commit comments

Comments
 (0)