Skip to content

Commit bfa611d

Browse files
committed
fixup! fixup! fix: fallback to gauge for protofmt-based negotiations
1 parent 4be2ddf commit bfa611d

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

pkg/metric/metric.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ type Type string
4444
type TypeN int
4545

4646
// String returns the string representation of the metric type.
47-
func (i TypeN) String() Type {
48-
return MetricTypeNMap[i]
47+
func (i TypeN) String() string {
48+
return string(TypeNMap[i])
4949
}
5050

5151
// NString returns the string representation of the metric type as an integer.
@@ -55,7 +55,7 @@ func (i TypeN) NString() string {
5555

5656
// Supported metric types.
5757
const (
58-
// GaugeN defines a OpenMetrics gauge.
58+
// GaugeN defines an OpenMetrics gauge.
5959
GaugeN TypeN = iota
6060

6161
// InfoN defines an OpenMetrics info.
@@ -64,14 +64,14 @@ const (
6464
// StateSetN defines an OpenMetrics stateset.
6565
StateSetN
6666

67-
// CounterN defines a OpenMetrics counter.
67+
// CounterN defines an OpenMetrics counter.
6868
CounterN
6969
)
7070

7171
// Supported metric types.
7272
var (
7373

74-
// Gauge defines a OpenMetrics gauge.
74+
// Gauge defines an OpenMetrics gauge.
7575
Gauge Type = "gauge"
7676

7777
// Info defines an OpenMetrics info.
@@ -80,19 +80,19 @@ var (
8080
// StateSet defines an OpenMetrics stateset.
8181
StateSet Type = "stateset"
8282

83-
// Counter defines a OpenMetrics counter.
83+
// Counter defines an OpenMetrics counter.
8484
Counter Type = "counter"
8585

86-
// MetricTypeNMap is a map of MetricTypeN to MetricType.
87-
MetricTypeNMap = map[TypeN]Type{
86+
// TypeNMap is a map of MetricTypeN to MetricType.
87+
TypeNMap = map[TypeN]Type{
8888
GaugeN: Gauge,
8989
InfoN: Info,
9090
StateSetN: StateSet,
9191
CounterN: Counter,
9292
}
9393

94-
// MetricTypeMap is a map of MetricType to MetricTypeN.
95-
MetricTypeMap = map[Type]TypeN{
94+
// TypeMap is a map of MetricType to MetricTypeN.
95+
TypeMap = map[Type]TypeN{
9696
Gauge: GaugeN,
9797
Info: InfoN,
9898
StateSet: StateSetN,

pkg/metric_generator/generator.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ func (g *FamilyGenerator) generateHeader() string {
9090
header.WriteString("# TYPE ")
9191
header.WriteString(g.Name)
9292
header.WriteByte(' ')
93-
header.WriteString(metric.MetricTypeMap[g.Type].NString())
93+
header.WriteString(metric.TypeMap[g.Type].NString())
9494

9595
return header.String()
9696
}

pkg/metrics_store/metrics_writer.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,8 @@ func SanitizeHeaders(contentType string, writers MetricsWriterList) MetricsWrite
115115

116116
// Replace all remaining type enums with their string representations.
117117
n := int(header[len(header)-1]) - '0'
118-
if n >= 0 && n < len(metric.MetricTypeNMap) {
119-
writer.stores[0].headers[i] = header[:len(header)-1] + string(metric.MetricTypeNMap[metric.TypeN(n)])
118+
if n >= 0 && n < len(metric.TypeNMap) {
119+
writer.stores[0].headers[i] = header[:len(header)-1] + string(metric.TypeNMap[metric.TypeN(n)])
120120
}
121121
}
122122
}

0 commit comments

Comments
 (0)