remove ok variable and change the type of v variable to map

Author: whitebear009

internal/store/horizontalpodautoscaler.go

@@ -36,8 +36,6 @@ const (
 	value metricTargetType = iota
 	utilization
 	average
-
-	metricTargetTypeCount // Used as a length argument to arrays
 )
 
 func (m metricTargetType) String() string {
@@ -134,55 +132,53 @@ func hpaMetricFamilies(allowAnnotationsList, allowLabelsList []string) []generat
 				for _, m := range a.Spec.Metrics {
 					var metricName string
 
-					var v [metricTargetTypeCount]float64
-					var ok [metricTargetTypeCount]bool
+					// The variable maps the type of metric to the corresponding value
+					metricMap := make(map[metricTargetType]float64)
 
 					switch m.Type {
 					case autoscaling.ObjectMetricSourceType:
 						metricName = m.Object.Metric.Name
 
 						if m.Object.Target.Value != nil {
-							v[value], ok[value] = float64(m.Object.Target.Value.MilliValue())/1000, true
+							metricMap[value] = float64(m.Object.Target.Value.MilliValue()) / 1000
 						}
 						if m.Object.Target.AverageValue != nil {
-							v[average], ok[average] = float64(m.Object.Target.AverageValue.MilliValue())/1000, true
+							metricMap[average] = float64(m.Object.Target.AverageValue.MilliValue()) / 1000
 						}
 					case autoscaling.PodsMetricSourceType:
 						metricName = m.Pods.Metric.Name
 
-						v[average], ok[average] = float64(m.Pods.Target.AverageValue.MilliValue())/1000, true
+						metricMap[average] = float64(m.Pods.Target.AverageValue.MilliValue()) / 1000
 					case autoscaling.ResourceMetricSourceType:
 						metricName = string(m.Resource.Name)
 
 						if m.Resource.Target.AverageUtilization != nil {
-							v[utilization], ok[utilization] = float64(*m.Resource.Target.AverageUtilization), true
+							metricMap[utilization] = float64(*m.Resource.Target.AverageUtilization)
 						}
 
 						if m.Resource.Target.AverageValue != nil {
-							v[average], ok[average] = float64(m.Resource.Target.AverageValue.MilliValue())/1000, true
+							metricMap[average] = float64(m.Resource.Target.AverageValue.MilliValue()) / 1000
 						}
 					case autoscaling.ExternalMetricSourceType:
 						metricName = m.External.Metric.Name
 
 						if m.External.Target.Value != nil {
-							v[value], ok[value] = float64(m.External.Target.Value.MilliValue())/1000, true
+							metricMap[value] = float64(m.External.Target.Value.MilliValue()) / 1000
 						}
 						if m.External.Target.AverageValue != nil {
-							v[average], ok[average] = float64(m.External.Target.AverageValue.MilliValue())/1000, true
+							metricMap[average] = float64(m.External.Target.AverageValue.MilliValue()) / 1000
 						}
 					default:
 						// Skip unsupported metric type
 						continue
 					}
 
-					for i := range ok {
-						if ok[i] {
-							ms = append(ms, &metric.Metric{
-								LabelKeys:   targetMetricLabels,
-								LabelValues: []string{metricName, metricTargetType(i).String()},
-								Value:       v[i],
-							})
-						}
+					for metricTypeIndex, metricValue := range metricMap {
+						ms = append(ms, &metric.Metric{
+							LabelKeys:   targetMetricLabels,
+							LabelValues: []string{metricName, metricTypeIndex.String()},
+							Value:       metricValue,
+						})
 					}
 				}
 				return &metric.Family{Metrics: ms}