Apply suggestions from code review

mrueg · web-flow · commit c67f02f0f376 · 2024-11-05T10:58:10.000+01:00
diff --git a/internal/store/utils.go b/internal/store/utils.go
@@ -218,7 +218,7 @@ func mergeKeyValues(keyValues ...[]string) (keys, values []string) {
 	return keys, values
 }
 
-// convertValueToFloat64 converts a resource.Quantity to a float64.
+// convertValueToFloat64 converts a resource.Quantity to a float64 and checks for a possible overflow in the value.
 func convertValueToFloat64(q *resource.Quantity) float64 {
 	if q.Value() > resource.MaxMilliValue {
 		return float64(q.Value())

Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,7 @@ func mergeKeyValues(keyValues ...[]string) (keys, values []string) {`
`218`	`218`	`return keys, values`
`219`	`219`	`}`
`220`	`220`
`221`		`-// convertValueToFloat64 converts a resource.Quantity to a float64.`
	`221`	`+// convertValueToFloat64 converts a resource.Quantity to a float64 and checks for a possible overflow in the value.`
`222`	`222`	`func convertValueToFloat64(q *resource.Quantity) float64 {`
`223`	`223`	`if q.Value() > resource.MaxMilliValue {`
`224`	`224`	`return float64(q.Value())`